Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Issue 2151103002: [cpu-profiler] Do not record empty stack trace. (Closed)

Created:
4 years, 5 months ago by alph
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cpu-profiler] Do not record empty stack trace. When it is in executing JS state there should be a JS stack. Having no stack means something is wrong with frame pointer, so just skip the bogus sample. Committed: https://crrev.com/7e1d1fc708b9072ee460f24bf3ccf26c0b4a2a21 Cr-Commit-Position: refs/heads/master@{#37802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M src/profiler/tick-sample.cc View 1 chunk +20 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alph
Yang, please take a look.
4 years, 5 months ago (2016-07-14 23:15:19 UTC) #4
Yang
lgtm
4 years, 5 months ago (2016-07-15 11:12:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151103002/1
4 years, 5 months ago (2016-07-15 17:17:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 17:20:47 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 17:22:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e1d1fc708b9072ee460f24bf3ccf26c0b4a2a21
Cr-Commit-Position: refs/heads/master@{#37802}

Powered by Google App Engine
This is Rietveld 408576698