Support symbol literals.

sdk/lib/_internal/compiler/implementation/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   Element get currentElement;
   Set<Node> get superUses;
 
@@ skipping 2470 matching lines @@
   }
 
   visitLiteralString(LiteralString node) {
     world.registerInstantiatedClass(compiler.stringClass, mapping);
   }
 
   visitLiteralNull(LiteralNull node) {
     world.registerInstantiatedClass(compiler.nullClass, mapping);
   }
 
+  visitLiteralSymbol(LiteralSymbol node) {

[ngeoffray, 2013/09/04 07:14:17]

You should report that to the backend!!! :-) You could just use the scheme with
world.registerInstantiatedClass, that also registers it to the backend, and the
backend recognizes literal types.

[Johnni Winther, 2013/09/10 09:09:07]

Done.

+    world.registerInstantiatedClass(compiler.symbolClass, mapping);
+    world.registerStaticUse(compiler.symbolConstructor.declaration);
+    world.registerConstSymbol(node.slowNameString, mapping);
+    if (!validateSymbol(node, node.slowNameString, reportError: false)) {
+      compiler.reportError(node, MessageKind.UNSUPPORTED_LITERAL_SYMBOL,
+                           {'value': node.slowNameString});
+    }
+  }
+
   visitStringJuxtaposition(StringJuxtaposition node) {
     world.registerInstantiatedClass(compiler.stringClass, mapping);
     node.visitChildren(this);
   }
 
   visitNodeList(NodeList node) {
     for (Link<Node> link = node.nodes; !link.isEmpty; link = link.tail) {
       visit(link.head);
     }
   }
@@ skipping 171 matching lines @@
         }
         world.registerNewSymbol(mapping);
       }
     } else if (isMirrorsUsedConstant) {
       compiler.mirrorUsageAnalyzerTask.validate(node, mapping);
     }
 
     return null;
   }
 
-  bool validateSymbol(Node node, String name) {
+  bool validateSymbol(Node node, String name, {bool reportError: true}) {
     if (name.isEmpty) return true;
     if (name.startsWith('_')) {
-      compiler.reportError(node, MessageKind.PRIVATE_IDENTIFIER,
-                               {'value': name});
+      if (reportError) {
+        compiler.reportError(node, MessageKind.PRIVATE_IDENTIFIER,
+                             {'value': name});
+      }
       return false;
     }
     if (!symbolValidationPattern.hasMatch(name)) {
-      compiler.reportError(node, MessageKind.INVALID_SYMBOL,
-                               {'value': name});
+      if (reportError) {
+        compiler.reportError(node, MessageKind.INVALID_SYMBOL,
+                             {'value': name});
+      }
       return false;
     }
     return true;
   }
 
 
   /**
    * Try to resolve the constructor that is referred to by [node].
    * Note: this function may return an ErroneousFunctionElement instead of
    * [null], if there is no corresponding constructor, class or library.
@@ skipping 1391 matching lines @@
     return e;
   }
 
   /// Assumed to be called by [resolveRedirectingFactory].
   Element visitReturn(Return node) {
     Node expression = node.expression;
     return finishConstructorReference(visit(expression),
                                       expression, expression);
   }
 }