Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473
Committed: https://crrev.com/22c22eb7ec4280b8310a5b2404fe7a86a6e01e65
Cr-Commit-Position: refs/heads/master@{#419226}

[kylechar, 2016-09-15 19:39:12]

Description was changed from

==========
Run mus_demo_unittests on Ozone trybot.

BUG=611473
==========

to

==========
Run mus_demo_unittests on Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473
==========

[kylechar, 2016-09-15 19:40:28]

Description was changed from

==========
Run mus_demo_unittests on Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473
==========

to

==========
Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473
==========

[kylechar, 2016-09-15 19:46:14]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-09-15 20:22:58]

As long as there isn't any flake in this (generally shown by running on an fyi
bot for a while) LGTM

[kylechar, 2016-09-15 20:29:05]

On 2016/09/15 20:22:58, sky wrote:
> As long as there isn't any flake in this (generally shown by running on an fyi
> bot for a while) LGTM

This hasn't been running on the FYI bot yet. I'll change this patch to modify
FYI instead and wait to see?

[sky, 2016-09-15 20:29:33]

SGTM

On Thu, Sep 15, 2016 at 1:29 PM,  <kylechar@chromium.org> wrote:
> On 2016/09/15 20:22:58, sky wrote:
>> As long as there isn't any flake in this (generally shown by running on an
>> fyi
>> bot for a while) LGTM
>
> This hasn't been running on the FYI bot yet. I'll change this patch to
> modify
> FYI instead and wait to see?
>
> https://codereview.chromium.org/2151093003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[kylechar, 2016-09-16 14:30:29]

On 2016/09/15 20:29:33, sky wrote:
> SGTM
> 
> On Thu, Sep 15, 2016 at 1:29 PM,  <mailto:kylechar@chromium.org> wrote:
> > On 2016/09/15 20:22:58, sky wrote:
> >> As long as there isn't any flake in this (generally shown by running on an
> >> fyi
> >> bot for a while) LGTM
> >
> > This hasn't been running on the FYI bot yet. I'll change this patch to
> > modify
> > FYI instead and wait to see?
> >
> > https://codereview.chromium.org/2151093003/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

Hmm, there is no X11 Chrome OS FYI bot to test this on, only the Ozone Chrome OS
FYI bot (which it won't run properly on). Using the same GN args as the trybot I
haven't had any issues with it failing locally. So I'm relatively sure it won't
have problems with being flakey. I'll try it on the actual trybot and revert if
there is a problem?

[sky, 2016-09-16 16:49:40]

Go for it. LGTM

[kylechar, 2016-09-16 16:59:10]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-09-16 17:00:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:34:47]

Description was changed from

==========
Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473
==========

to

==========
Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473
==========

[commit-bot: I haz the power, 2016-09-16 18:34:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 18:38:30]

Description was changed from

==========
Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473
==========

to

==========
Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473

Committed: https://crrev.com/22c22eb7ec4280b8310a5b2404fe7a86a6e01e65
Cr-Commit-Position: refs/heads/master@{#419226}
==========

[commit-bot: I haz the power, 2016-09-16 18:38:31]

Patchset 3 (id:??) landed as
https://crrev.com/22c22eb7ec4280b8310a5b2404fe7a86a6e01e65
Cr-Commit-Position: refs/heads/master@{#419226}