Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2151063003: Enable PKP tests on Android. (Closed)

Created:
4 years, 5 months ago by dadrian
Modified:
4 years, 5 months ago
Reviewers:
eroman, davidben, estark
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PKP tests on Android. Android now supports dynamic pins, but not static pins. BUG=517311 Committed: https://crrev.com/2faf206e6af040f101f1bb3c8743332ed88a9a2d Cr-Commit-Position: refs/heads/master@{#405904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M net/url_request/url_request_unittest.cc View 5 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dadrian
I've been in this file a lot recently...
4 years, 5 months ago (2016-07-15 21:07:21 UTC) #2
dadrian
Actually, it looks like davidben@ is out of town, adding eroman@ for net/ review.
4 years, 5 months ago (2016-07-15 21:40:50 UTC) #4
estark
lgtm
4 years, 5 months ago (2016-07-15 21:48:39 UTC) #5
eroman
lgtm
4 years, 5 months ago (2016-07-15 23:07:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151063003/1
4 years, 5 months ago (2016-07-15 23:11:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-16 00:03:30 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-16 00:03:33 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:05:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2faf206e6af040f101f1bb3c8743332ed88a9a2d
Cr-Commit-Position: refs/heads/master@{#405904}

Powered by Google App Engine
This is Rietveld 408576698