Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 2151053002: Add #! lines and +x scripts run by the build system (Closed)

Created:
4 years, 5 months ago by jamesr
Modified:
4 years, 5 months ago
Reviewers:
zra
CC:
abarth-chromium, reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add \#! lines and +x scripts run by the build system This makes these build scripts directly runnable instead of the build system having to know out-of-band that these are python.

Patch Set 1 #

Patch Set 2 : Add #! lines and +x scripts run by the build system #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --2 lines) Patch
A runtime/tools/create_resources.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A runtime/tools/gen_library_src_paths.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/gypi_to_gn.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/make_version.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jamesr
This is useful for us in the fuchsia build as our build system doesn't assume ...
4 years, 5 months ago (2016-07-14 19:29:21 UTC) #3
zra
lgtm chromium.googlesource.com is just a mirror of the github repo, so I think you may ...
4 years, 5 months ago (2016-07-14 19:34:32 UTC) #4
jamesr
On 2016/07/14 at 19:34:32, zra wrote: > lgtm > > chromium.googlesource.com is just a mirror ...
4 years, 5 months ago (2016-07-14 19:36:32 UTC) #5
jamesr
PS2 includes create_resources.py
4 years, 5 months ago (2016-07-14 19:37:06 UTC) #6
zra
On 2016/07/14 19:36:32, jamesr wrote: > On 2016/07/14 at 19:34:32, zra wrote: > > lgtm ...
4 years, 5 months ago (2016-07-14 19:41:48 UTC) #7
jamesr
On 2016/07/14 at 19:41:48, zra wrote: > On 2016/07/14 19:36:32, jamesr wrote: > > On ...
4 years, 5 months ago (2016-07-14 19:42:57 UTC) #8
zra
4 years, 5 months ago (2016-07-14 19:47:37 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698