Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2151033003: Add SkGpuDevice::asSpecial entry point (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -39 lines) Patch
M src/gpu/SkGpuDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 4 chunks +25 lines, -39 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
4 years, 5 months ago (2016-07-14 21:23:30 UTC) #4
robertphillips
ping
4 years, 5 months ago (2016-07-15 12:15:16 UTC) #9
bsalomon
lgtm w/ q https://codereview.chromium.org/2151033003/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/2151033003/diff/20001/src/gpu/SkGpuDevice.cpp#newcode1405 src/gpu/SkGpuDevice.cpp:1405: return nullptr; Should we attempt a ...
4 years, 5 months ago (2016-07-15 14:53:31 UTC) #10
robertphillips
https://codereview.chromium.org/2151033003/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/2151033003/diff/20001/src/gpu/SkGpuDevice.cpp#newcode1405 src/gpu/SkGpuDevice.cpp:1405: return nullptr; On 2016/07/15 14:53:31, bsalomon wrote: > Should ...
4 years, 5 months ago (2016-07-15 14:59:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151033003/20001
4 years, 5 months ago (2016-07-15 14:59:58 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 15:01:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1b5f968103aea6c1ef95f696c2c78bbf44d01d17

Powered by Google App Engine
This is Rietveld 408576698