[Files.app] Hide video-player related task menu according to condition

chrome/browser/resources/file_manager/foreground/js/file_tasks.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * This object encapsulates everything related to tasks execution.
  *
  * TODO(hirono): Pass each component instead of the entire FileManager.
@@ skipping 28 matching lines @@
 /**
  * Base URL of apps list in the Chrome Web Store. This constant is used in
  * FileTasks.createWebStoreLink().
  *
  * @const
  * @type {string}
  */
 FileTasks.WEB_STORE_HANDLER_BASE_URL =
     'https://chrome.google.com/webstore/category/collection/file_handlers';
 
+
+/**
+ * The app ID of the video player app.
+ * @const
+ * @type {string}
+ */
+FileTasks.VIDEO_PLAYER_ID = 'jcgeabjmjgoblfofpppfkcoakmfobdko';
+
 /**
  * Returns URL of the Chrome Web Store which show apps supporting the given
  * file-extension and mime-type.
  *
  * @param {string} extension Extension of the file (with the first dot).
  * @param {string} mimeType Mime type of the file.
  * @return {string} URL
  */
 FileTasks.createWebStoreLink = function(extension, mimeType) {
   if (!extension)
@@ skipping 123 matching lines @@
 FileTasks.isInternalTask_ = function(taskId) {
   var taskParts = taskId.split('|');
   var appId = taskParts[0];
   var taskType = taskParts[1];
   var actionId = taskParts[2];
   // The action IDs here should match ones used in executeInternalTask_().
   return (appId === chrome.runtime.id &&
           taskType === 'file' &&
           (actionId === 'play' ||
            actionId === 'mount-archive' ||
-           actionId === 'gallery'));
+           actionId === 'gallery' ||
+           actionId === 'gallery-video'));
 };
 
 /**
  * Processes internal tasks.
  *
  * @param {Array.<Object>} tasks The tasks.
  * @private
  */
 FileTasks.prototype.processTasks_ = function(tasks) {
   this.tasks_ = [];
   var id = chrome.runtime.id;
   var isOnDrive = false;
   var fm = this.fileManager_;
+  var isMultiple = (this.entries_.length > 1);
   for (var index = 0; index < this.entries_.length; ++index) {
     var locationInfo = fm.volumeManager.getLocationInfo(this.entries_[index]);
     if (locationInfo && locationInfo.isDriveBased) {
       isOnDrive = true;
       break;
     }
   }
 
   for (var i = 0; i < tasks.length; i++) {
     var task = tasks[i];
     var taskParts = task.taskId.split('|');
 
     // Skip internal Files.app's handlers.
     if (taskParts[0] === id && (taskParts[2] === 'auto-open' ||
         taskParts[2] === 'select' || taskParts[2] === 'open')) {
       continue;
     }
 
+    // Skip video player app if multiple files are selected.

[hirono, 2014/03/28 05:35:22]

Not so strong opinion.
How about filtering the tasks in C++ if the JavaScript code does not need to
know the tasks?

[yoshiki, 2014/03/28 06:53:10]

Done.

+    if (isMultiple &&
+        taskParts[0] === FileTasks.VIDEO_PLAYER_ID &&
+        taskParts[1] === 'app' &&
+        taskParts[2] === 'video') {
+      continue;
+    }
+
+    // Skip gallaly (video mode) if a single files is selected.
+    if (!isMultiple &&
+        taskParts[0] === id &&
+        taskParts[1] === 'file' &&
+        taskParts[2] === 'gallery-video') {
+      continue;
+    }
+
     // Tweak images, titles of internal tasks.
     if (taskParts[0] === id && taskParts[1] === 'file') {
       if (taskParts[2] === 'play') {
         // TODO(serya): This hack needed until task.iconUrl is working
         //             (see GetFileTasksFileBrowserFunction::RunImpl).
         task.iconType = 'audio';
         task.title = loadTimeData.getString('ACTION_LISTEN');
       } else if (taskParts[2] === 'mount-archive') {
         task.iconType = 'archive';
         task.title = loadTimeData.getString('MOUNT_ARCHIVE');
-      } else if (taskParts[2] === 'gallery') {
+      } else if (taskParts[2] === 'gallery' ||
+                 taskParts[2] === 'gallery-video') {
         task.iconType = 'image';
         task.title = loadTimeData.getString('ACTION_OPEN');
       } else if (taskParts[2] === 'open-hosted-generic') {
         if (this.entries_.length > 1)

[hirono, 2014/03/28 05:35:22]

isMultiple

           task.iconType = 'generic';
         else // Use specific icon.
           task.iconType = FileType.getIcon(this.entries_[0]);
         task.title = loadTimeData.getString('ACTION_OPEN');
       } else if (taskParts[2] === 'open-hosted-gdoc') {
         task.iconType = 'gdoc';
         task.title = loadTimeData.getString('ACTION_OPEN_GDOC');
       } else if (taskParts[2] === 'open-hosted-gsheet') {
         task.iconType = 'gsheet';
         task.title = loadTimeData.getString('ACTION_OPEN_GSHEET');
@@ skipping 296 matching lines @@
                                           displayedId);
     });
     return;
   }
 
   if (id === 'mount-archive') {
     this.mountArchivesInternal_(entries);
     return;
   }
 
-  if (id === 'gallery') {
+  if (id === 'gallery' || id === 'gallery-video') {
     this.openGalleryInternal_(entries);
     return;
   }
 
   console.error('Unexpected action ID: ' + id);
 };
 
 /**
  * Mounts archives.
  *
@@ skipping 284 matching lines @@
       this.pendingInvocations_.push([privateMethod, arguments]);
     }
     return this;
   };
 };
 
 FileTasks.decorate('display');
 FileTasks.decorate('updateMenuItem');
 FileTasks.decorate('execute');
 FileTasks.decorate('executeDefault');