[Files.app] Hide video-player related task menu according to condition

[Files.app] Hide video-player related task menu according to condition

This patch does following.:
- Hide "Open" (open in gallery with movie mode) if a single file is selected
- Hide "Watch" (open in video player) if multiple files are selected

Before the movie player separation, the task menu behaved as above, but it was removed in the previous patch (https://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/file_manager/file_browser_handlers.cc?r1=259219&r2=259218&pathrev=259219). This patch changes the behaviour back with the new video player.

BUG=271811
TEST=manually tested
R=hashimoto@chromium.org, hirono@chromium.org
TBR=asargent@chromium.orh
# TBRing for removing the comment.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260134

[yoshiki, 2014-03-28 03:59:09]

@hirono, PTAL. Thanks.

[hirono, 2014-03-28 05:35:22]

Thanks!

https://codereview.chromium.org/215103003/diff/1/chrome/browser/extensions/co...
File chrome/browser/extensions/component_loader.cc (left):

https://codereview.chromium.org/215103003/diff/1/chrome/browser/extensions/co...
chrome/browser/extensions/component_loader.cc:443: // Note: Video player should
be avove the file manager, since the video
Why the comments are removed?

https://codereview.chromium.org/215103003/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/215103003/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:234: // Skip
video player app if multiple files are selected.
Not so strong opinion.
How about filtering the tasks in C++ if the JavaScript code does not need to
know the tasks?

https://codereview.chromium.org/215103003/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:265: if
(this.entries_.length > 1)
isMultiple

[yoshiki, 2014-03-28 06:53:10]

@hirono, @hashimoto: PTAL. Thanks.

https://codereview.chromium.org/215103003/diff/1/chrome/browser/extensions/co...
File chrome/browser/extensions/component_loader.cc (left):

https://codereview.chromium.org/215103003/diff/1/chrome/browser/extensions/co...
chrome/browser/extensions/component_loader.cc:443: // Note: Video player should
be avove the file manager, since the video
On 2014/03/28 05:35:22, hirono wrote:
> Why the comments are removed?

Because, we no longer need to care about the load order.

https://codereview.chromium.org/215103003/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/foreground/js/file_tasks.js (right):

https://codereview.chromium.org/215103003/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/foreground/js/file_tasks.js:234: // Skip
video player app if multiple files are selected.
On 2014/03/28 05:35:22, hirono wrote:
> Not so strong opinion.
> How about filtering the tasks in C++ if the JavaScript code does not need to
> know the tasks?

Done.

[hirono, 2014-03-28 07:36:04]

Thanks lgtm!

[hashimoto, 2014-03-28 07:57:09]

https://codereview.chromium.org/215103003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/215103003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:114:
FindTaskForExtensionIdAndActionId(
nit: FindTaskForAppIdAndActionId? The argument is named |app_id|.

https://codereview.chromium.org/215103003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:134: void
ChooseSuitableVideoHandler(
This new function is not used?

[yoshiki, 2014-03-28 09:09:53]

@hashimoto: Sorry, I fotget uploading the latest patchset. PTAL. Thanks.

[hashimoto, 2014-03-28 09:28:59]

chrome/browser/chromeos/file_manager/ lgtm

https://codereview.chromium.org/215103003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/215103003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:114:
FindTaskForExtensionIdAndActionId(
On 2014/03/28 07:57:10, hashimoto wrote:
> nit: FindTaskForAppIdAndActionId? The argument is named |app_id|.

ping?

[yoshiki, 2014-03-28 09:31:27]

https://codereview.chromium.org/215103003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/215103003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:114:
FindTaskForExtensionIdAndActionId(
On 2014/03/28 09:28:59, hashimoto wrote:
> On 2014/03/28 07:57:10, hashimoto wrote:
> > nit: FindTaskForAppIdAndActionId? The argument is named |app_id|.
> 
> ping?

Done.

[yoshiki, 2014-03-28 09:31:48]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2014-03-28 09:31:48]

The CQ bit was unchecked by yoshiki@chromium.org

[yoshiki, 2014-03-28 09:31:49]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-03-28 09:33:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/215103003/80001

[commit-bot: I haz the power, 2014-03-28 10:14:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 10:14:47]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[yoshiki, 2014-03-28 10:21:00]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-03-28 10:21:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/215103003/80001

[commit-bot: I haz the power, 2014-03-28 15:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 15:23:35]

Retried try job too often on ios_dbg_simulator for step(s) components_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[yoshiki, 2014-03-28 15:25:49]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-03-28 15:27:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/215103003/80001

[yoshiki, 2014-03-28 15:35:45]

Committed patchset #4 manually as r260134 (presubmit successful).