Do not try to v8::Object::Clone() any objects

Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

Remove FXJS_NewObject() and FXJS_NewObject2(), and replace with
direct assignments.  Pass isolate to FXJS_NewNull() while were
at it, even though not needed, for consistency with all remaining
FXJS_New*() calls.

BUG=628106
R=jochen@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/88b6686f6e56a01dab0172f4b3129ab7ae0cd8d8

[Tom Sepez, 2016-07-14 18:28:23]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 18:28:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-07-14 18:29:48]

Description was changed from

==========
Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

BUG=628106
R=jochen@chromium.org
==========

to

==========
Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

Remove FXJS_NewObject() and FXJS_NewObject2, and replace with
direct assignments.  Pass isolate to FXJS_NewNull() while were
at it, even though not needed, for consistency with all remaining
FXJS_New*() calls.

BUG=628106
R=jochen@chromium.org
==========

[Tom Sepez, 2016-07-14 18:30:55]

Jochen, please review.

[Tom Sepez, 2016-07-14 18:35:22]

Description was changed from

==========
Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

Remove FXJS_NewObject() and FXJS_NewObject2, and replace with
direct assignments.  Pass isolate to FXJS_NewNull() while were
at it, even though not needed, for consistency with all remaining
FXJS_New*() calls.

BUG=628106
R=jochen@chromium.org
==========

to

==========
Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

Remove FXJS_NewObject() and FXJS_NewObject2(), and replace with
direct assignments.  Pass isolate to FXJS_NewNull() while were
at it, even though not needed, for consistency with all remaining
FXJS_New*() calls.

BUG=628106
R=jochen@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-07-14 18:42:21]

if that works, lgtm, great!

[Tom Sepez, 2016-07-14 18:47:39]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:48:46]

Dry run: Try jobs failed on following builders:
  win_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_rel_gyp...)

[Tom Sepez, 2016-07-14 18:48:58]

On 2016/07/14 18:42:21, jochen wrote:
> if that works, lgtm, great!

+dan, FYI.

I think this works, but the symptom of it not working would be weird aliasing
between objects in JS, right?

[Tom Sepez, 2016-07-14 18:57:52]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 19:07:52]

Description was changed from

==========
Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

Remove FXJS_NewObject() and FXJS_NewObject2(), and replace with
direct assignments.  Pass isolate to FXJS_NewNull() while were
at it, even though not needed, for consistency with all remaining
FXJS_New*() calls.

BUG=628106
R=jochen@chromium.org
==========

to

==========
Do not try to v8::Object::Clone() any objects

v8::Object::Clone() is deprecated, and gets us into trouble with
some corner cases.  Create a new handle to the same object instead.

Remove FXJS_NewObject() and FXJS_NewObject2(), and replace with
direct assignments.  Pass isolate to FXJS_NewNull() while were
at it, even though not needed, for consistency with all remaining
FXJS_New*() calls.

BUG=628106
R=jochen@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/88b6686f6e56a01dab0172f4b3129ab7ae0c...
==========

[commit-bot: I haz the power, 2016-07-14 19:07:53]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/88b6686f6e56a01dab0172f4b3129ab7ae0c...