Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2151013002: Convert some GN test support targets to static libs. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, johnme+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, aboxhall+watch_chromium.org, chromoting-reviews_chromium.org, abarth-chromium, jbauman+watch_chromium.org, je_julie, blink-reviews, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, tapted, Peter Beverloo, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, rjkroege, Ian Vollick, tfarina, nektar+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some GN test support targets to static libs. Converts some source sets that were source sets into static libraries. Converts additional targets in the touched files to static libraries where it seemed relevant. A few redundant dependencies were removed (one shouldn't need to specify both "foo" and "foo:test_support"). A few empty source sets were converted to groups. BUG=627637 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a Cr-Commit-Position: refs/heads/master@{#405593}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remoting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ipc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/test_support/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/signaling/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/background/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/cpp/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M services/ui/public/cpp/tests/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M sql/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/presenter/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
brettw
4 years, 5 months ago (2016-07-14 18:11:07 UTC) #3
brettw
.
4 years, 5 months ago (2016-07-14 18:11:19 UTC) #4
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 18:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151013002/20001
4 years, 5 months ago (2016-07-14 18:32:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/245192)
4 years, 5 months ago (2016-07-14 18:39:45 UTC) #12
brettw
remoting
4 years, 5 months ago (2016-07-14 19:11:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151013002/40001
4 years, 5 months ago (2016-07-14 19:11:45 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 22:08:51 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:12:39 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a
Cr-Commit-Position: refs/heads/master@{#405593}

Powered by Google App Engine
This is Rietveld 408576698