Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html

Issue 2150993004: [DevTools] Remove V8Debugger::consoleMessagesCount. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html b/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html
index 2780a40b14420bfa45b84a7797600c741ce4a554..35ba19e806132817979a442dc7272552849c5c12 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html
@@ -1,6 +1,7 @@
<html>
<head>
-<script src="resources/console-clear-arguments-test.js"></script>
+<script src="../inspector/inspector-test.js"></script>
+<script src="../inspector/console-test.js"></script>
<script>
if (window.testRunner) {
@@ -16,17 +17,25 @@ function frameLoaded(event) {
return;
}
- dumpConsoleMessageCounts();
if (window.testRunner)
- testRunner.notifyDone();
+ testRunner.showWebInspector();
+ runTest();
}
+function test()
+{
+ for (var message of InspectorTest.mainTarget.consoleModel.messages()) {
+ var args = (message.parameters || []).map((arg) => arg.type);
+ InspectorTest.addResult("Message: \"" + message.messageText + "\", arguments: [" + args.join(", ") + "]");
+ }
+ InspectorTest.completeTest();
+}
</script>
</head>
<body>
<p>
-Tests that Web Inspector will discard console message arguments when iframe where the message was
+Tests that Web Inspector will discard console message arguments and convert first argument into a string when iframe where the message was
logged is navigated to a different page.
</p>
<iframe id="theFrame" onload="frameLoaded(event)" src="resources/console-clear-arguments-iframe.html"></iframe>

Powered by Google App Engine
This is Rietveld 408576698