Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2150983003: Fix audio_manager_unittest should update with AudioDevice display_name (Closed)

Created:
4 years, 5 months ago by Qiang(Joe) Xu
Modified:
4 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix audio_manager_unittest should update with AudioDevice display_name In later patch of https://codereview.chromium.org/2079843003/, I update the code to display AudioDevice display_name. But I forget to update the unittest. Since try server is not running in USE_CRAS, it is not detected. BUG=628342 TEST=run in USE_CRAS building condition, it returns to work fine. Committed: https://crrev.com/aff7677aba5777c766d7d5a57a77ad71cbb6ff24 Cr-Commit-Position: refs/heads/master@{#405579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M media/audio/audio_manager_unittest.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Qiang(Joe) Xu
Hi Tomas, could you help review on this? It is my miss that in the ...
4 years, 5 months ago (2016-07-14 19:04:17 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 5 months ago (2016-07-14 20:14:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150983003/1
4 years, 5 months ago (2016-07-14 20:15:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 21:34:51 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 21:35:24 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:36:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aff7677aba5777c766d7d5a57a77ad71cbb6ff24
Cr-Commit-Position: refs/heads/master@{#405579}

Powered by Google App Engine
This is Rietveld 408576698