MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

Fixes browser crash.

BUG=628159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7e921d98243a6aa5a481436ec300f83942e376d0
Cr-Commit-Position: refs/heads/master@{#405554}

[dpapad, 2016-07-14 17:40:17]

Description was changed from

==========
MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

BUG=628159
==========

to

==========
MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

BUG=628159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-14 17:40:21]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 17:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-07-14 17:41:17]

Description was changed from

==========
MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

BUG=628159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

Fixes browser crash.

BUG=628159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-14 17:42:03]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-14 18:34:09]

it mildly pains me to ask, but how is this different than
https://codereview.chromium.org/2133893002/?  should we be observing some global
service to detect changes or conversely setting some global flag and ignoring if
it's already set?

there is a DCHECK(!GetResetter()->IsActive()) above the crash, but it'd refer to
different objects in different handlers:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/reset_s...

[Dan Beam, 2016-07-14 18:35:39]

i guess for this specific manifestation this is an improvement.  it'd be a
little better to prevent this globally as well, though...

lgtm with a TODO() to consider this.  for what it's worth: this seems a little
different that CBD, as the same result is guaranteed no matter what you do, I'd
bet (unless running 2 of these resetter things at once isn't safe).

[Dan Beam, 2016-07-14 18:37:40]

On 2016/07/14 18:35:39, Dan Beam wrote:
> i guess for this specific manifestation this is an improvement.  it'd be a
> little better to prevent this globally as well, though...

"this specific manifestation" -> that the button is easily clickable twice
(whereas CBD wasn't), and that you're technically fixing the bug described at
BUG=628159

> 
> lgtm with a TODO() to consider this.  for what it's worth: this seems a little
> different that CBD, as the same result is guaranteed no matter what you do,
I'd
> bet (unless running 2 of these resetter things at once isn't safe).

[commit-bot: I haz the power, 2016-07-14 19:08:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:08:30]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dpapad, 2016-07-14 19:15:08]

Added a TODO to evaluate whether this needs to be synced across tabs, similar to
CBD. This CL is still an improvement, since double clicking this button should
not be allowed.

[dpapad, 2016-07-14 19:15:38]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-07-14 19:15:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2150983002/#ps20001
(title: "Added TODO")

[commit-bot: I haz the power, 2016-07-14 19:16:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 20:25:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 20:26:50]

Description was changed from

==========
MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

Fixes browser crash.

BUG=628159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

Fixes browser crash.

BUG=628159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7e921d98243a6aa5a481436ec300f83942e376d0
Cr-Commit-Position: refs/heads/master@{#405554}
==========

[commit-bot: I haz the power, 2016-07-14 20:26:51]

Patchset 2 (id:??) landed as
https://crrev.com/7e921d98243a6aa5a481436ec300f83942e376d0
Cr-Commit-Position: refs/heads/master@{#405554}