Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2150963002: tools/roll*: use master.tryserver instead of tryserver (Closed)

Created:
4 years, 5 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
CC:
chromium-reviews, Ken Russell (switch to Gerrit), kjellander_chromium, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/roll*: use master.tryserver instead of tryserver BUG=617627 TBR=kjellander@chromium.org Committed: https://crrev.com/65854075e069afd2c5be3fbebc9c99cf36e5b59e Cr-Commit-Position: refs/heads/master@{#405543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M tools/roll_angle.py View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/roll_webgl_conformance.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/roll_webrtc.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Corentin Wallez
dpranke: PTAL Others: FYI
4 years, 5 months ago (2016-07-14 17:36:01 UTC) #2
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-14 17:46:57 UTC) #4
Dirk Pranke
I don't know these scripts, so I defer to tandrii@ here, who hopefully does.
4 years, 5 months ago (2016-07-14 18:31:14 UTC) #5
tandrii(chromium)
On 2016/07/14 18:31:14, Dirk Pranke wrote: > I don't know these scripts, so I defer ...
4 years, 5 months ago (2016-07-14 18:33:41 UTC) #6
Corentin Wallez
On 2016/07/14 at 18:33:41, tandrii wrote: > On 2016/07/14 18:31:14, Dirk Pranke wrote: > > ...
4 years, 5 months ago (2016-07-14 18:39:53 UTC) #7
tandrii(chromium)
On 2016/07/14 18:39:53, Corentin Wallez wrote: > On 2016/07/14 at 18:33:41, tandrii wrote: > > ...
4 years, 5 months ago (2016-07-14 18:54:31 UTC) #8
Corentin Wallez
On 2016/07/14 at 18:54:31, tandrii wrote: > On 2016/07/14 18:39:53, Corentin Wallez wrote: > > ...
4 years, 5 months ago (2016-07-14 18:55:44 UTC) #11
Dirk Pranke
oh, this is in chromium. sure, lgtm
4 years, 5 months ago (2016-07-14 18:55:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150963002/1
4 years, 5 months ago (2016-07-14 18:56:24 UTC) #13
Ken Russell (switch to Gerrit)
LGTM. Thanks for the cleanup.
4 years, 5 months ago (2016-07-14 18:59:25 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 19:38:19 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65854075e069afd2c5be3fbebc9c99cf36e5b59e Cr-Commit-Position: refs/heads/master@{#405543}
4 years, 5 months ago (2016-07-14 19:40:13 UTC) #18
kjellander_chromium
4 years, 5 months ago (2016-07-24 09:40:54 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698