Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2150913002: Update URLRequestTestHTTP.GetZippedTest test assertions (Closed)

Created:
4 years, 5 months ago by xunjieli
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update URLRequestTestHTTP.GetZippedTest test assertions This test adds a new test assertion in GetZippedTest to check the contents of decoded response body. BUG=474859 Committed: https://crrev.com/fb4da222efae1457bcbbc96e9e307462feb82c56 Cr-Commit-Position: refs/heads/master@{#405522}

Patch Set 1 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M net/url_request/url_request_unittest.cc View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
xunjieli
Randy: This is a small CL to make test assertions stronger. While doing the net::Filter ...
4 years, 5 months ago (2016-07-14 15:27:06 UTC) #3
Randy Smith (Not in Mondays)
lgtm
4 years, 5 months ago (2016-07-14 18:22:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150913002/20001
4 years, 5 months ago (2016-07-14 18:31:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-14 18:39:15 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 18:41:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb4da222efae1457bcbbc96e9e307462feb82c56
Cr-Commit-Position: refs/heads/master@{#405522}

Powered by Google App Engine
This is Rietveld 408576698