chrome/browser/permissions/permission_bubble_request_impl.cc - Issue 2150903002: Reland add hooks to permission layer for permission action reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 2150903002: Reland add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_bubble_request_impl.cc

diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc

index 20017753f8c837f8a765390fe0888fbc495a50ee..e2389b16d0db1cafbd280cadd0e362866c5d3875 100644

--- a/chrome/browser/permissions/permission_bubble_request_impl.cc

+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc

@@ -29,7 +29,9 @@ PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(

PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {

DCHECK(is_finished_);

if (!action_taken_)

- PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_);

+ // TODO(stefanocs): Pass in a non null profile.

+ PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_,

+ nullptr);

}

gfx::VectorIconId PermissionBubbleRequestImpl::GetVectorIconId() const {

« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »