Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2150883002: Revert of Color: Don't duplicate ICC profile data (Closed)

Created:
4 years, 5 months ago by magjed_chromium
Modified:
4 years, 5 months ago
Reviewers:
hubbe, Dan Beam, ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Color: Don't duplicate ICC profile data (patchset #4 id:60001 of https://codereview.chromium.org/2140803002/ ) Reason for revert: Breaks bot https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/4992 It's not allowed to add new callbacks to AtExitManager while the callbacks are already being processed. So that lazy global data is causing trouble. [3972:940:0713/225822:FATAL:at_exit.cc(60)] Check failed: !g_top_manager->processing_callbacks_. Backtrace: base::debug::StackTrace::StackTrace [0x02F60BB7+23] logging::LogMessage::~LogMessage [0x02F1D2E1+49] base::AtExitManager::RegisterTask [0x02F61AAA+186] base::AtExitManager::RegisterCallback [0x02F619D9+137] base::internal::CompleteLazyInstance [0x02F3F2EB+27] base::LazyInstance<base::Lock,base::DefaultLazyInstanceTraits<base::Lock> >::Pointer [0x01483E7A+47] base::RefCountedThreadSafe<gfx::ColorSpace::GlobalData,base::DefaultRefCountedThreadSafeTraits<gfx::ColorSpace::GlobalData> >::DeleteInternal [0x038E9685+17] gfx::ColorSpace::~ColorSpace [0x038E9505+14] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void const *),void const *>,void __cdecl(void)>::Run [0x02F61AFE+14] base::AtExitManager::ProcessCallbacksNow [0x02F61894+388] base::AtExitManager::~AtExitManager [0x02F616D3+163] std::default_delete<base::AtExitManager>::operator() [0x0169C6FD+17] base::TestSuite::~TestSuite [0x02FB1D0D+44] content::LaunchTests [0x049A02D7+592] LaunchChromeTests [0x02F13585+49] main [0x00D0B49E+94] __scrt_common_main_seh [0x04A0EC12+255] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255) BaseThreadInitThunk [0x766E338A+18] RtlInitializeExceptionChain [0x77D49902+99] RtlInitializeExceptionChain [0x77D498D5+54] Original issue's description: > Color: Don't duplicate ICC profile data > > Make gfx::ColorSpace have an internal pointer to a globally-unique > structure for the color space, where its ICC profile can be stored. > > BUG=622133 > > Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320 > Committed: https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65 > Cr-Original-Commit-Position: refs/heads/master@{#405211} > Cr-Commit-Position: refs/heads/master@{#405424} TBR=hubbe@chromium.org,dbeam@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622133 Committed: https://crrev.com/653c72f34282bcb1f6b118eec477d394b1dbcf1d Cr-Commit-Position: refs/heads/master@{#405463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -126 lines) Patch
M ui/gfx/color_space.h View 4 chunks +2 lines, -17 lines 0 comments Download
M ui/gfx/color_space.cc View 3 chunks +5 lines, -103 lines 0 comments Download
M ui/gfx/color_space_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/color_space_x11.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_chromium
Created Revert of Color: Don't duplicate ICC profile data
4 years, 5 months ago (2016-07-14 10:17:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150883002/1
4 years, 5 months ago (2016-07-14 10:18:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 10:18:50 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 10:18:52 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 10:20:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/653c72f34282bcb1f6b118eec477d394b1dbcf1d
Cr-Commit-Position: refs/heads/master@{#405463}

Powered by Google App Engine
This is Rietveld 408576698