service worker: Don't BadMessageReceived when a response for a timed out request arrives

service worker: Don't BadMessageReceived when a response for a timed out request arrives

If the worker is stopping, assume an unhandled message is due to the
request timing out which triggered the stopping.

I considered saving timed out request ids but it's a bit cumbersome: you
have to store the IPC message type along with the request id which involves
some changes to PendingRequest along with the data structure to hold
the timed out requests. Seems more trouble than it's worth to avoid this bug,
and we expect to migrate to Mojo soon anyway.

BUG=625040
Committed: https://crrev.com/b321c36b95fa43f0378ce82a222b89224d030a6a
Cr-Commit-Position: refs/heads/master@{#405477}

[falken, 2016-07-14 07:15:01]

falken@chromium.org changed reviewers:
+ nhiroki@chromium.org

[falken, 2016-07-14 07:15:01]

ptal

[nhiroki, 2016-07-14 10:35:27]

lgtm

https://codereview.chromium.org/2150863002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/2150863002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_dispatcher_host_unittest.cc:789:
// message count should not increase.
nit: a position of starting a new line looks odd.

[falken, 2016-07-14 11:05:28]

Thanks

https://codereview.chromium.org/2150863002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/2150863002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_dispatcher_host_unittest.cc:789:
// message count should not increase.
On 2016/07/14 10:35:27, nhiroki (slow) wrote:
> nit: a position of starting a new line looks odd.

Done.

https://codereview.chromium.org/2150863002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_dispatcher_host_unittest.cc:794:
EXPECT_EQ(0, dispatcher_host_->bad_messages_received_count_);
I also realized this should move after RunUntilIdle.

[falken, 2016-07-14 11:05:37]

The CQ bit was checked by falken@chromium.org

[falken, 2016-07-14 11:05:37]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2150863002/#ps20001
(title: "comment and move expect")

[commit-bot: I haz the power, 2016-07-14 11:06:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 12:19:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 12:20:17]

Description was changed from

==========
service worker: Don't BadMessageReceived when a response for a timed out request
arrives

If the worker is stopping, assume an unhandled message is due to the
request timing out which triggered the stopping.

I considered saving timed out request ids but it's a bit cumbersome: you
have to store the IPC message type along with the request id which involves
some changes to PendingRequest along with the data structure to hold
the timed out requests. Seems more trouble than it's worth to avoid this bug,
and we expect to migrate to Mojo soon anyway.

BUG=625040
==========

to

==========
service worker: Don't BadMessageReceived when a response for a timed out request
arrives

If the worker is stopping, assume an unhandled message is due to the
request timing out which triggered the stopping.

I considered saving timed out request ids but it's a bit cumbersome: you
have to store the IPC message type along with the request id which involves
some changes to PendingRequest along with the data structure to hold
the timed out requests. Seems more trouble than it's worth to avoid this bug,
and we expect to migrate to Mojo soon anyway.

BUG=625040

Committed: https://crrev.com/b321c36b95fa43f0378ce82a222b89224d030a6a
Cr-Commit-Position: refs/heads/master@{#405477}
==========

[commit-bot: I haz the power, 2016-07-14 12:20:18]

Patchset 2 (id:??) landed as
https://crrev.com/b321c36b95fa43f0378ce82a222b89224d030a6a
Cr-Commit-Position: refs/heads/master@{#405477}