[ash-md] Implements a shadow over overview items and selector

[ash-md] Implements a shadow over overview items and selector

This is non-MD 9-patch shadow just to test drive the looks.
Effectively this patch preserves the regular ash window shadows
and applies them in overview.

BUG=608852
Committed: https://crrev.com/52d1403822a5014d32e01274cd8c3f669e181cc0
Cr-Commit-Position: refs/heads/master@{#405932}

[varkha, 2016-07-14 01:02:13]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 01:02:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-14 01:05:06]

Description was changed from

==========
[ash-md] Implements a shadow over overview items and selector

This is non-MD 9-patch shadow just to test drive the looks.

BUG=608852
==========

to

==========
[ash-md] Implements a shadow over overview items and selector

This is non-MD 9-patch shadow just to test drive the looks.
Effectively this patch preserves the regular ash window shadows
and applies them in overview.

BUG=608852
==========

[varkha, 2016-07-14 01:05:41]

varkha@chromium.org changed reviewers:
+ sadrul@chromium.org

[varkha, 2016-07-14 01:05:42]

sadrul@, can you please take a look? Thanks!

[commit-bot: I haz the power, 2016-07-14 01:54:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 01:54:55]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-07-15 01:58:46]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[varkha, 2016-07-15 01:58:59]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-07-15 01:59:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 03:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 03:46:49]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-07-15 15:09:57]

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_grid.cc:923: }
Since |selector_shadow_|'s layer is a child of the |selection_widget_|'s layer,
the animations applied for the widget should normally apply on the shadow layer
too (I think?). Is this block of code trying to prevent that from happening?

[varkha, 2016-07-15 16:18:01]

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_grid.cc:923: }
On 2016/07/15 15:09:57, sadrul wrote:
> Since |selector_shadow_|'s layer is a child of the |selection_widget_|'s
layer,
> the animations applied for the widget should normally apply on the shadow
layer
> too (I think?). Is this block of code trying to prevent that from happening?

Without calling SetContentBounds() on a Shadow I get the wrong (old) size of a
shadow so it looks wrong for tiles of different sizes. I think this is because
the Shadow class needs to reclculate images when the shape or size changes.
Without setting |animation_settings_shadow| I see the shadow size snapping
immediately to the right size and then animating position when
|selection_widget_| animates. I think this is because SeContentBounds updates
the shadow images immediately.
So you are correct, parent layer animations do apply but it only helps with
motion, not with resize.

[sadrul, 2016-07-16 02:12:37]

lgtm

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_grid.cc:841:
widget_window->GetLayer()->Add(selector_shadow_->layer());
Can you use selection_widget_->GetLayer() instead?

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_selector_item.cc:567:
window_label_window->GetLayer()->SetMasksToBounds(false);
Do you need to lookup the WmWindow? Can you use window_label_->GetLayer()
directly instead?

[varkha, 2016-07-16 03:35:47]

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_grid.cc:841:
widget_window->GetLayer()->Add(selector_shadow_->layer());
On 2016/07/16 02:12:37, sadrul wrote:
> Can you use selection_widget_->GetLayer() instead?

Done.

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
File ash/common/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/2150823002/diff/20001/ash/common/wm/overview/...
ash/common/wm/overview/window_selector_item.cc:567:
window_label_window->GetLayer()->SetMasksToBounds(false);
On 2016/07/16 02:12:37, sadrul wrote:
> Do you need to lookup the WmWindow? Can you use window_label_->GetLayer()
> directly instead?

Done.

[varkha, 2016-07-16 03:35:58]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-07-16 03:35:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2150823002/#ps40001
(title: "[ash-md] Implements a shadow over overview items and selector (nits)")

[commit-bot: I haz the power, 2016-07-16 03:36:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 04:24:10]

Description was changed from

==========
[ash-md] Implements a shadow over overview items and selector

This is non-MD 9-patch shadow just to test drive the looks.
Effectively this patch preserves the regular ash window shadows
and applies them in overview.

BUG=608852
==========

to

==========
[ash-md] Implements a shadow over overview items and selector

This is non-MD 9-patch shadow just to test drive the looks.
Effectively this patch preserves the regular ash window shadows
and applies them in overview.

BUG=608852
==========

[commit-bot: I haz the power, 2016-07-16 04:24:12]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-16 04:24:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-16 04:26:02]

Description was changed from

==========
[ash-md] Implements a shadow over overview items and selector

This is non-MD 9-patch shadow just to test drive the looks.
Effectively this patch preserves the regular ash window shadows
and applies them in overview.

BUG=608852
==========

to

==========
[ash-md] Implements a shadow over overview items and selector

This is non-MD 9-patch shadow just to test drive the looks.
Effectively this patch preserves the regular ash window shadows
and applies them in overview.

BUG=608852

Committed: https://crrev.com/52d1403822a5014d32e01274cd8c3f669e181cc0
Cr-Commit-Position: refs/heads/master@{#405932}
==========

[commit-bot: I haz the power, 2016-07-16 04:26:03]

Patchset 2 (id:??) landed as
https://crrev.com/52d1403822a5014d32e01274cd8c3f669e181cc0
Cr-Commit-Position: refs/heads/master@{#405932}