Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js

Issue 2150803002: [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
index 90b6e26eb3094f165579c19764584e056d03a8a4..30b917c9cd7555e6d67916d047491a173afdbe65 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
@@ -4,16 +4,17 @@
/**
* @constructor
+ * @param {!RuntimeAgent.CallFrame} callFrame
*/
-WebInspector.ProfileNode = function(functionName, scriptId, url, lineNumber, columnNumber)
+WebInspector.ProfileNode = function(callFrame)
{
/** @type {!RuntimeAgent.CallFrame} */
this.frame = {
alph 2016/07/14 17:56:00 The plan was to have this.frame = callFrame;
kozy 2016/07/14 21:35:04 Done.
- functionName: functionName,
- scriptId: scriptId,
- url: url,
- lineNumber: lineNumber,
- columnNumber: columnNumber
+ functionName: callFrame.functionName,
+ scriptId: callFrame.scriptId,
+ url: callFrame.url,
+ lineNumber: callFrame.lineNumber + 1,
dgozman 2016/07/14 15:58:28 Are you going to migrate frontend code in the next
kozy 2016/07/14 21:35:04 It was first plan, added migration right here.
+ columnNumber: callFrame.columnNumber + 1
};
/** @type {number|string} */
this.callUID;

Powered by Google App Engine
This is Rietveld 408576698