third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js - Issue 2150803002: [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

Issue 2150803002: [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

index 24404a69af4658c21ddcf269d3be7de690311cc2..a34972c5b2d269e8a41667c3fbcefcedae0a51e2 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

@@ -221,7 +221,7 @@ WebInspector.SamplingHeapProfileHeader.prototype = {

WebInspector.SamplingHeapProfileNode = function(node)

{

- WebInspector.ProfileNode.call(this, node.functionName, node.scriptId, node.url, node.lineNumber, node.columnNumber);

+ WebInspector.ProfileNode.call(this, node.callFrame);

alph 2016/07/14 17:56:00 I guess we need to retain backward compatibility i

kozy 2016/07/14 21:35:04 Done.

this.self = node.selfSize;

this.callUID = `${this.frame.functionName}@${this.frame.scriptId}:${this.frame.lineNumber}`;

}