Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 215073005: Notify cacheinvalidations about network status (Closed)

Created:
6 years, 8 months ago by pavely
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Notify cacheinvalidations about network status Cacheinvalidations retries sending messages when network becomes available and some time has passed since last attempt to send message. This change is to notify cacheinvalidations about network status change. Switch to transient error only when sending message failed. Switch to INVALIDATIONS_ENABLED to let cacheinvalidations retry when network changes. BUG=325020 R=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M sync/notifier/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sync/notifier/gcm_network_channel.h View 3 chunks +6 lines, -0 lines 0 comments Download
M sync/notifier/gcm_network_channel.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M sync/notifier/gcm_network_channel_unittest.cc View 8 chunks +43 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pavely
6 years, 8 months ago (2014-03-28 00:12:33 UTC) #1
rlarocque
lgtm
6 years, 8 months ago (2014-03-28 00:31:12 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 8 months ago (2014-03-28 00:37:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/215073005/1
6 years, 8 months ago (2014-03-28 00:39:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 01:16:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58165
6 years, 8 months ago (2014-03-28 01:16:50 UTC) #6
pavely
+Ryan for sync/notifier/DEPS: I added network_change_notifier.h to DEPS
6 years, 8 months ago (2014-03-28 05:34:41 UTC) #7
Ryan Hamilton
net lgtm
6 years, 8 months ago (2014-03-28 14:55:52 UTC) #8
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 8 months ago (2014-03-28 15:50:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/215073005/1
6 years, 8 months ago (2014-03-28 15:53:09 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 20:59:18 UTC) #11
Message was sent while issue was closed.
Change committed as 260271

Powered by Google App Engine
This is Rietveld 408576698