Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 215073002: WebContents could be blocked after pending cross-site navigation is canceled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert RFH::SwapOut() change Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 868b9dd5c1379e1e80b0d388ebe08e6a309ee0d7..93d21faa4fb8933b87fa196cd1a7b63db3e05f57 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -565,8 +565,12 @@ void RenderFrameHostImpl::OnBeforeUnloadACK(
// If this renderer navigated while the beforeunload request was in flight, we
// may have cleared this state in OnNavigate, in which case we can ignore
// this message.
- if (!render_view_host_->is_waiting_for_beforeunload_ack_ ||
- render_view_host_->rvh_state_ != RenderViewHostImpl::STATE_DEFAULT) {
+ // However renderer might also be swapped out but we still want to proceed
+ // with navigation, otherwise it would block future navigations. This can
+ // happen when pending cross-site navigation is canceled by a second one just
+ // before OnNavigate while current RVH is waiting for commit but second
+ // navigation is started from the beginning.
+ if (!render_view_host_->is_waiting_for_beforeunload_ack_) {
return;
}
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698