[Devtools] Refactor NetworkLogViewColumns to be dynamic

third_party/WebKit/Source/devtools/front_end/common/Settings.js

Index: third_party/WebKit/Source/devtools/front_end/common/Settings.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/Settings.js b/third_party/WebKit/Source/devtools/front_end/common/Settings.js
index b5e159e9f3cc7f6f996e232df35da8a6b8a36d07..ada81d8e4110e5797a35107c3b2f3699954fab38 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/Settings.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/Settings.js
@@ -399,7 +399,7 @@ WebInspector.VersionController = function()
 }
 
 WebInspector.VersionController._currentVersionName = "inspectorVersion";
-WebInspector.VersionController.currentVersion = 18;
+WebInspector.VersionController.currentVersion = 19;
 
 WebInspector.VersionController.prototype = {
     updateVersion: function()
@@ -699,6 +699,32 @@ WebInspector.VersionController.prototype = {
         }
         setting.set(newValue);
     },
+    _updateVersionFrom18To19: function()
+    {
+        var defaultColumns = {
+            status: true,
+            type: true,
+            initiator: true,
+            size: true,
+            time: true
+        };
+        var visibleColumnSettings = WebInspector.settings.createSetting("networkLogColumnsVisibility", defaultColumns);
+        var visibleColumns = visibleColumnSettings.get();
+        visibleColumns.name = true;
+        visibleColumns.timeline = true;
+
+        var configs = {};
+        for (var columnId in visibleColumns) {
+            if (!visibleColumns.hasOwnProperty(columnId))
+                continue;
+            configs[columnId.toLowerCase()] = {
+                visible: visibleColumns[columnId]
+            };
+        }
+        var newSetting = WebInspector.settings.createSetting("networkLogColumns", {})

[dgozman, 2016/07/14 05:28:06]

semicolons please!

[allada, 2016/07/14 22:27:07]

Done.

+        newSetting.set(configs);
+        visibleColumnSettings.remove()
+    },
 
     _migrateSettingsFromLocalStorage: function()
     {