[Devtools] Refactor NetworkLogViewColumns to be dynamic

third_party/WebKit/Source/devtools/front_end/common/Settings.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 381 matching lines @@
 }
 
 /**
  * @constructor
  */
 WebInspector.VersionController = function()
 {
 }
 
 WebInspector.VersionController._currentVersionName = "inspectorVersion";
-WebInspector.VersionController.currentVersion = 18;
+WebInspector.VersionController.currentVersion = 19;
 
 WebInspector.VersionController.prototype = {
     updateVersion: function()
     {
         var localStorageVersion = window.localStorage ? window.localStorage[WebInspector.VersionController._currentVersionName] : 0;
         var versionSetting = WebInspector.settings.createSetting(WebInspector.VersionController._currentVersionName, 0);
         var currentVersion = WebInspector.VersionController.currentVersion;
         // While localStorage version exists, treat it as the main one. It'll be erased once migrated to prefs.
         var oldVersion = parseInt(localStorageVersion || "0", 10) || versionSetting.get();
         if (oldVersion === 0) {
@@ skipping 279 matching lines @@
             if (!newKey.startsWith("file://")) {
                 if (newKey.startsWith("/"))
                     newKey = "file://" + newKey;
                 else
                     newKey = "file:///" + newKey;
             }
             newValue[newKey] = oldValue[oldKey];
         }
         setting.set(newValue);
     },
+    _updateVersionFrom18To19: function()

[dgozman, 2016/07/15 23:47:49]

Blank line before function please.

[allada, 2016/07/25 23:05:53]

Done.

+    {
+        var defaultColumns = {
+            status: true,
+            type: true,
+            initiator: true,
+            size: true,
+            time: true
+        };
+        var visibleColumnSettings = WebInspector.settings.createSetting("networkLogColumnsVisibility", defaultColumns);
+        var visibleColumns = visibleColumnSettings.get();
+        visibleColumns.name = true;
+        visibleColumns.timeline = true;
+
+        var configs = {};
+        for (var columnId in visibleColumns) {
+            if (!visibleColumns.hasOwnProperty(columnId))
+                continue;
+            configs[columnId.toLowerCase()] = {
+                visible: visibleColumns[columnId]
+            };
+        }
+        var newSetting = WebInspector.settings.createSetting("networkLogColumns", {});
+        newSetting.set(configs);
+        visibleColumnSettings.remove()

[dgozman, 2016/07/15 23:47:49]

semicolons please!

[allada, 2016/07/25 23:05:53]

Done.

+    },
 
     _migrateSettingsFromLocalStorage: function()
     {
         // This step migrates all the settings except for the ones below into the browser profile.
         var localSettings = [ "advancedSearchConfig", "breakpoints", "consoleHistory", "domBreakpoints", "eventListenerBreakpoints",
                               "fileSystemMapping", "lastSelectedSourcesSidebarPaneTab", "previouslyViewedFiles",
                               "savedURLs", "watchExpressions", "workspaceExcludedFolders", "xhrBreakpoints" ].keySet();
         if (!window.localStorage)
             return;
 
@@ skipping 34 matching lines @@
 }
 
 /**
  * @param {string} settingName
  * @return {!WebInspector.Setting}
  */
 WebInspector.settingForTest = function(settingName)
 {
     return WebInspector.settings.settingForTest(settingName);
 }