Issue 21507: Experimental: port bleeding_edge r1276 (a grab bag of optimizations)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21507: Experimental: port bleeding_edge r1276 (a grab bag of optimizations)... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: port bleeding_edge r1276 (a grab bag of optimizations) to the code generator branch. The only file that really needs to be looked at is codegen-ia32.cc. The others were merged by svn without issue. Committed: http://code.google.com/p/v8/source/detail?r=1315

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -61 lines)			Patch
M	src/array.js	View	5 chunks	+35 lines, -20 lines	0 comments	Download
M	src/codegen-ia32.cc	View	3 chunks	+28 lines, -8 lines	2 comments	Download
M	src/date-delay.js	View	4 chunks	+31 lines, -21 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp-inl.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/string.js	View	6 chunks	+25 lines, -8 lines	0 comments	Download
M	src/v8natives.js	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	test/mjsunit/date.js	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/21507/diff/1/8 File src/codegen-ia32.cc (right): http://codereview.chromium.org/21507/diff/1/8#newcode1205 Line 1205: __ or_(Operand(opernand.reg()), Immediate(value)); "opernand" typo?

11 years, 10 months ago (2009-02-19 12:19:37 UTC) #2

Kevin Millikin (Chromium)

http://codereview.chromium.org/21507/diff/1/8 File src/codegen-ia32.cc (right): http://codereview.chromium.org/21507/diff/1/8#newcode1205 Line 1205: __ or_(Operand(opernand.reg()), Immediate(value)); On 2009/02/19 12:19:37, Lasse Reichstein ...

11 years, 10 months ago (2009-02-19 12:21:06 UTC) #3

LGTM.

Expand Messages | Collapse Messages