Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 215063004: Reset multipliers correctly when autosizing is turned off. (Closed)

Created:
6 years, 9 months ago by skobes
Modified:
6 years, 9 months ago
Reviewers:
pdr, pdr., esprehn
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink, boliu, mnaganov (inactive), timvolodine, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Reset multipliers correctly when autosizing is turned off. This lets us re-land http://crrev.com/208393008 without breaking AwSettingsTest.testLayoutAlgorithmWithTwoViews. Without http://crrev.com/208393008, style recalc would always reset the autosizing multiplier to 1, so the bug in recalculateMultipliers was not noticed. BUG=353309, 356960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170241

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add initializer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/rendering/TextAutosizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/TextAutosizer.cpp View 1 4 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
skobes
6 years, 9 months ago (2014-03-27 23:00:46 UTC) #1
esprehn
https://codereview.chromium.org/215063004/diff/1/Source/core/rendering/TextAutosizer.h File Source/core/rendering/TextAutosizer.h (right): https://codereview.chromium.org/215063004/diff/1/Source/core/rendering/TextAutosizer.h#newcode143 Source/core/rendering/TextAutosizer.h:143: bool m_previouslyAutosized; You don't initialize this in the constructor.
6 years, 9 months ago (2014-03-27 23:10:16 UTC) #2
pdr.
LGTM! https://codereview.chromium.org/215063004/diff/1/Source/core/rendering/TextAutosizer.h File Source/core/rendering/TextAutosizer.h (right): https://codereview.chromium.org/215063004/diff/1/Source/core/rendering/TextAutosizer.h#newcode143 Source/core/rendering/TextAutosizer.h:143: bool m_previouslyAutosized; Do we need to initialize this?
6 years, 9 months ago (2014-03-27 23:12:04 UTC) #3
skobes
https://codereview.chromium.org/215063004/diff/1/Source/core/rendering/TextAutosizer.h File Source/core/rendering/TextAutosizer.h (right): https://codereview.chromium.org/215063004/diff/1/Source/core/rendering/TextAutosizer.h#newcode143 Source/core/rendering/TextAutosizer.h:143: bool m_previouslyAutosized; On 2014/03/27 23:10:16, esprehn wrote: > You ...
6 years, 9 months ago (2014-03-27 23:17:24 UTC) #4
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 9 months ago (2014-03-27 23:17:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/215063004/20001
6 years, 9 months ago (2014-03-27 23:17:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:21:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 23:21:10 UTC) #8
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 9 months ago (2014-03-27 23:21:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/215063004/20001
6 years, 9 months ago (2014-03-27 23:21:47 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:24:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 23:24:17 UTC) #12
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 9 months ago (2014-03-27 23:25:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/215063004/20001
6 years, 9 months ago (2014-03-27 23:25:34 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:25:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 00:25:36 UTC) #16
pdr
The CQ bit was checked by pdr@google.com
6 years, 9 months ago (2014-03-28 00:36:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/215063004/20001
6 years, 9 months ago (2014-03-28 00:36:12 UTC) #18
skobes
The CQ bit was unchecked by skobes@chromium.org
6 years, 9 months ago (2014-03-28 00:49:51 UTC) #19
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 9 months ago (2014-03-28 00:52:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/215063004/20001
6 years, 9 months ago (2014-03-28 00:52:23 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 01:45:13 UTC) #22
Message was sent while issue was closed.
Change committed as 170241

Powered by Google App Engine
This is Rietveld 408576698