Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: gyp/expat.gyp

Issue 2150603004: Build Expat on all platforms (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: trim obsolete comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | gyp/xml.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/expat.gyp
diff --git a/gyp/expat.gyp b/gyp/expat.gyp
index 9e18383db35ae6eaec71cd89227b1e5f4ab5081d..90f7b02fbc597d6dc085eb27c92a082c7b7a772f 100644
--- a/gyp/expat.gyp
+++ b/gyp/expat.gyp
@@ -4,15 +4,18 @@
# found in the LICENSE file.
# Build expat from source.
-# Used on Linux bots for testing the Android FontMgr xml parsing.
-# This is mostly important for the MSAN bot's instrumentation.
{
'targets': [{
'target_name': 'expat',
'type': 'static_library',
- 'cflags': [ '-w' ],
- 'defines': [ 'HAVE_MEMMOVE' ],
+ 'cflags': [ '-Wno-missing-field-initializers' ],
+ 'xcode_settings': { 'WARNING_CFLAGS': [ '-Wno-missing-field-initializers', ], },
+ 'msvs_disabled_warnings': [4244],
+ 'defines': [ 'HAVE_EXPAT_CONFIG_H' ],
+ 'include_dirs': [
+ '../third_party/externals/expat',
+ ],
'sources': [
'../third_party/externals/expat/lib/xmlparse.c',
'../third_party/externals/expat/lib/xmlrole.c',
« no previous file with comments | « DEPS ('k') | gyp/xml.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698