Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2150583003: V8. ASM-2-WASM. Small fixes. (Closed)

Created:
4 years, 5 months ago by John
Modified:
4 years, 5 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

V8. ASM-2-WASM. Small fixes. 1) Validation fails for literal indexes too large for accessing a given heap type 2) Removes the special handling of FloatishDoubleQ, and FloatQDoubleQ; the inheritance issue that required this special handling was fixed in another CL. 3) Fix a macro name (from asm_* to ASM_*) BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=cctest/asmjs/test-asm-typer.cc LOG=N Committed: https://crrev.com/43d3187e7a70c742b78226effbf10d0c99b9179c Cr-Commit-Position: refs/heads/master@{#37776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -50 lines) Patch
M src/asmjs/asm-typer.cc View 5 chunks +30 lines, -23 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 6 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
John
4 years, 5 months ago (2016-07-14 16:04:46 UTC) #6
bradnelson
lgtm
4 years, 5 months ago (2016-07-14 16:37:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150583003/1
4 years, 5 months ago (2016-07-14 16:37:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 16:39:54 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 16:41:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43d3187e7a70c742b78226effbf10d0c99b9179c
Cr-Commit-Position: refs/heads/master@{#37776}

Powered by Google App Engine
This is Rietveld 408576698