Annotated functions/classes more cleanly kept

chrome/android/java/proguard.flags

 # Keep line number information, useful for stack traces.
 -keepattributes SourceFile,LineNumberTable
 
 # Keep the annotations.
 -keep @interface ***
 
 # Disable obfuscation for the following two packages.
 -keepnames class com.google.android.apps.chrome.**,org.chromium.** {
   *;
 }
 
 # Fragments are loaded using reflection via Fragment.instantiate(Context,String)
 # This can be improved upon - see crbug.com/622023.
 -keep public class com.google.android.apps.chrome** extends android.app.Fragment
 -keep public class org.chromium** extends android.app.Fragment
 
 # Keeps for class level annotations.
--keep @**.UsedByReflection class *
--keep @**.VisibleForTesting class *
+-keep @org.chromium.base.annotations.UsedByReflection class com.google.android.apps.chrome.**

[agrieve, 2016/07/15 14:44:34]

I think we're fine to leave the right-hand-side of this as "class *". I don't
know why we'd not have code in our namespace, but if we did, I'd want the
annotation to still work.

I think we should probably do the same for the -kepclasseswithmembers below as
well.  Now that we've being more specific on the annotation class, we can relax
the right-hand side (and have fewer lines, yay!)

+-keep @org.chromium.base.annotations.UsedByReflection class org.chromium.**
+-keep @org.chromium.base.VisibleForTesting class com.google.android.apps.chrome.**
+-keep @org.chromium.base.VisibleForTesting class org.chromium.**
 
 # Keeps for method level annotations.
 -keepclasseswithmembers class com.google.android.apps.chrome.** {
-  @**.AccessedByNative <fields>;
+  @org.chromium.base.annotations.AccessedByNative <fields>;
 }
 -keepclasseswithmembers class com.google.android.apps.chrome.** {
-  @**.CalledByNative <methods>;
+  @org.chromium.base.annotations.CalledByNative <methods>;
 }
 -keepclasseswithmembers class com.google.android.apps.chrome.** {
-  @**.CalledByNativeUnchecked <methods>;
+  @org.chromium.base.annotations.CalledByNativeUnchecked <methods>;
 }
 -keepclasseswithmembers class com.google.android.apps.chrome.** {
-  @**.JavascriptInterface <methods>;
+  @org.chromium.base.annotations.NativeCall <methods>;
 }
 -keepclasseswithmembers class com.google.android.apps.chrome.** {
-  @**.NativeCall <methods>;
+  @org.chromium.base.annotations.UsedByReflection <methods>;
 }
 -keepclasseswithmembers class com.google.android.apps.chrome.** {
-  @**.UsedByReflection <methods>;
-}
--keepclasseswithmembers class com.google.android.apps.chrome.** {
-  @**.VisibleForTesting <methods>;
+  @org.chromium.base.VisibleForTesting <methods>;
 }
 -keepclasseswithmembers class com.google.android.apps.chrome.** {
   native <methods>;
 }
 -keepclasseswithmembers class org.chromium.** {
-  @**.AccessedByNative <fields>;
+  @org.chromium.base.annotations.AccessedByNative <fields>;
 }
 -keepclasseswithmembers class org.chromium.** {
-  @**.CalledByNative <methods>;
+  @org.chromium.base.annotations.CalledByNative <methods>;
 }
 -keepclasseswithmembers class org.chromium.** {
-  @**.CalledByNativeUnchecked <methods>;
+  @org.chromium.base.annotations.CalledByNativeUnchecked <methods>;
 }
 -keepclasseswithmembers class org.chromium.** {
-  @**.JavascriptInterface <methods>;
+  @org.chromium.base.annotations.NativeCall <methods>;
 }
 -keepclasseswithmembers class org.chromium.** {
-  @**.NativeCall <methods>;
+  @org.chromium.base.annotations.UsedByReflection <methods>;
 }
 -keepclasseswithmembers class org.chromium.** {
-  @**.UsedByReflection <methods>;
-}
--keepclasseswithmembers class org.chromium.** {
-  @**.VisibleForTesting <methods>;
+  @org.chromium.base.VisibleForTesting <methods>;
 }
 -keepclasseswithmembers class org.chromium.** {
   native <methods>;
 }
 
 # Class merging provides negligible .dex size reduction and method count
 # reduction (about 0.3% improvement on method count, and 0.1% savings on size),
 # and it messes up stack traces if the classes are optimized. Thus, it is in our
 # best interests to turn it off. See crbug.com/620323
 -optimizations !class/merging/*
@@ skipping 141 matching lines @@
 # Needed for chrome_sync_shell_test_apk. Note - these do no affect chrome_apk's
 # size.
 -keep class org.chromium.sync.protocol.* { *; }
 
 # These resources are referenced in tests, but not in the real application.
 -keepclassmembers class org.chromium.chrome.R$id {
   int webapp_splash_space;
   int mr_chooser_list;
   int find_toolbar;
 }