Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2150533003: [css-grid] Constify track sizing algorithm (Closed)

Created:
4 years, 5 months ago by svillar
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Constify track sizing algorithm All the methods used to run the track sizing algorithm should not modify the state of LayoutGrid. We can safely const-ify all of them and remove the ugly const_cast in computeIntrinsicLogicalWidths(). No new tests needed as there is no change in behavior. BUG=627812 Committed: https://crrev.com/ae5148ba4a2c164b809d59c4bca390e77b5124c5 Cr-Commit-Position: refs/heads/master@{#405441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
svillar
Sending out for review
4 years, 5 months ago (2016-07-13 16:12:35 UTC) #3
jfernandez
I think this is a healthy change, so clearly LGTM.
4 years, 5 months ago (2016-07-13 17:55:40 UTC) #4
eae
LGTM
4 years, 5 months ago (2016-07-13 18:01:25 UTC) #5
cbiesinger
lgtm
4 years, 5 months ago (2016-07-13 19:35:13 UTC) #6
Manuel Rego
Nice! LGTM too.
4 years, 5 months ago (2016-07-14 05:27:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150533003/1
4 years, 5 months ago (2016-07-14 05:28:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 06:33:36 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 06:33:41 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 06:35:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae5148ba4a2c164b809d59c4bca390e77b5124c5
Cr-Commit-Position: refs/heads/master@{#405441}

Powered by Google App Engine
This is Rietveld 408576698