Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2150533002: Serialize data for LibraryElement.getImportsFor (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -22 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +45 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 5 chunks +38 lines, -6 lines 4 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 4 chunks +25 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 7 chunks +39 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-13 12:50:41 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2150533002/diff/1/pkg/compiler/lib/src/serialization/modelz.dart File pkg/compiler/lib/src/serialization/modelz.dart (right): https://codereview.chromium.org/2150533002/diff/1/pkg/compiler/lib/src/serialization/modelz.dart#newcode339 pkg/compiler/lib/src/serialization/modelz.dart:339: if (getter != null && getter.abstractField != null) ...
4 years, 5 months ago (2016-07-13 18:06:46 UTC) #3
Johnni Winther
https://codereview.chromium.org/2150533002/diff/1/pkg/compiler/lib/src/serialization/modelz.dart File pkg/compiler/lib/src/serialization/modelz.dart (right): https://codereview.chromium.org/2150533002/diff/1/pkg/compiler/lib/src/serialization/modelz.dart#newcode339 pkg/compiler/lib/src/serialization/modelz.dart:339: if (getter != null && getter.abstractField != null) { ...
4 years, 5 months ago (2016-07-15 08:15:21 UTC) #4
Johnni Winther
4 years, 5 months ago (2016-07-15 08:16:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5c5a46a6e1e04ef52837735f7458b5989ff3b0f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698