Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215053004: Revert "Remove the enable-d3d11 flag so that d3d11 is enabled by default." (Closed)

Created:
6 years, 9 months ago by Geoff Lang
Modified:
6 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "Remove the enable-d3d11 flag so that d3d11 is enabled by default." Holding off on this change until after the m35 branch. This reverts commit 31b59d6198fd447c8b0e7fdb02fb74367472e34e. BUG=258676 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260261

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase and update pixel_tests revision. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Geoff Lang
PTAL
6 years, 9 months ago (2014-03-27 18:59:35 UTC) #1
Zhenyao Mo
On 2014/03/27 18:59:35, Geoff Lang wrote: > PTAL LGTM
6 years, 9 months ago (2014-03-27 19:54:34 UTC) #2
Geoff Lang
The CQ bit was checked by geofflang@chromium.org
6 years, 9 months ago (2014-03-27 21:06:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/geofflang@chromium.org/215053004/20001
6 years, 9 months ago (2014-03-27 21:14:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:40:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58088
6 years, 9 months ago (2014-03-27 21:40:27 UTC) #6
Geoff Lang
piman: PTAL
6 years, 9 months ago (2014-03-28 17:41:41 UTC) #7
Geoff Lang
PTAL
6 years, 9 months ago (2014-03-28 19:59:22 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
6 years, 9 months ago (2014-03-28 20:01:21 UTC) #9
piman
lgtm
6 years, 9 months ago (2014-03-28 20:05:15 UTC) #10
Justin Novosad
6 years, 9 months ago (2014-03-28 20:26:27 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 manually as r260261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698