Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2150503002: Fix padding of dev tools network filters and make the bar thinner (Closed)

Created:
4 years, 5 months ago by damien
Modified:
4 years, 5 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uneven padding of network filters in the dev tools. Also makes the filter bar thinner. Screenshots: https://imgur.com/a/CClua First round of reviews here: https://codereview.chromium.org/2105023004 BUG=606897 TEST=open network panel, padding for selected filter (XHR, JS, CSS) should be even (see screenshots) Committed: https://crrev.com/7157ec4fd149f677b0f6203398520bcd82739fb6 Cr-Commit-Position: refs/heads/master@{#405154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/filter.css View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
damien
Here's a re-upload of https://codereview.chromium.org/2105023004 to have the same email in the account and the ...
4 years, 5 months ago (2016-07-13 09:50:59 UTC) #4
lushnikov
lgtm, thanks
4 years, 5 months ago (2016-07-13 13:36:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150503002/1
4 years, 5 months ago (2016-07-13 13:58:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150503002/1
4 years, 5 months ago (2016-07-13 13:59:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 15:14:25 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 15:17:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7157ec4fd149f677b0f6203398520bcd82739fb6
Cr-Commit-Position: refs/heads/master@{#405154}

Powered by Google App Engine
This is Rietveld 408576698