Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2150493003: Revert of [android] Correct the URL scheme colors in the Omnibox. (Closed)

Created:
4 years, 5 months ago by palmer
Modified:
4 years, 5 months ago
Reviewers:
Ted C, nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [android] Correct the URL scheme colors in the Omnibox. (patchset #6 id:100001 of https://codereview.chromium.org/2144443002/ ) Reason for revert: Assertion failures (?) in things that don't run during CQ: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35273 Original issue's description: > [android] Correct the URL scheme colors in the Omnibox. > > Make the empahsized "https:" scheme text match the connection state indicator > icon color. (In the new design, the color changed.) Also, per the new design, > don't emphasize (color) the scheme for Incognito or theme colors. > > BUG=626646 > TBR=tedchoc > > Committed: https://crrev.com/cfd0445d8d4756d778e1b324dc739a7c1e51b128 > Cr-Commit-Position: refs/heads/master@{#405258} TBR=tedchoc@chromium.org,nyquist@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626646 Committed: https://crrev.com/f1fc8423f6dc67e299b8ba829df99bf08de9030f Cr-Commit-Position: refs/heads/master@{#405343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M chrome/android/java/res/values/colors.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java View 2 chunks +15 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
palmer
Created Revert of [android] Correct the URL scheme colors in the Omnibox.
4 years, 5 months ago (2016-07-13 23:08:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150493003/1
4 years, 5 months ago (2016-07-13 23:09:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 23:10:58 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 23:11:19 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:12:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1fc8423f6dc67e299b8ba829df99bf08de9030f
Cr-Commit-Position: refs/heads/master@{#405343}

Powered by Google App Engine
This is Rietveld 408576698