cc: Eliminate refcount churn in prioritized tile's raster source.

cc: Eliminate refcount churn in prioritized tile's raster source.

This patch saves about 5% time during prepare tiles by eliminating
unnecessary refcount churn when copying prioritized tiles around in
the raster tile priority queues.

R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/9f7eaff141b728bca75df40e70d53edb6da25ce3
Cr-Commit-Position: refs/heads/master@{#405613}

[vmpstr, 2016-07-13 23:38:48]

Description was changed from

==========
cc: Eliminate refcount churn in prioritized tile's raster source.

This patch saves about 5% time during prepare tiles by eliminating
unnecessary refcount churn when copying prioritized tiles around in
the raster tile priority queues.

R=ericrk
==========

to

==========
cc: Eliminate refcount churn in prioritized tile's raster source.

This patch saves about 5% time during prepare tiles by eliminating
unnecessary refcount churn when copying prioritized tiles around in
the raster tile priority queues.

R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[vmpstr, 2016-07-13 23:41:34]

Please take a look.

[vmpstr, 2016-07-14 20:50:22]

vmpstr@chromium.org changed reviewers:
+ danakj@chromium.org

[vmpstr, 2016-07-14 20:50:22]

+danakj as well.

[danakj, 2016-07-14 21:19:08]

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h
File cc/tiles/prioritized_tile.h (left):

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h...
cc/tiles/prioritized_tile.h:22: PrioritizedTile(const PrioritizedTile& other);
Can it be DISALLOW_COPY_AND_ASSIGN?

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h
File cc/tiles/prioritized_tile.h (right):

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h...
cc/tiles/prioritized_tile.h:35: friend class PictureLayerTiling;
can it be gone?

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h...
cc/tiles/prioritized_tile.h:37: PrioritizedTile(Tile* tile,
can it be public?

[vmpstr, 2016-07-14 21:27:41]

PTAL

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h
File cc/tiles/prioritized_tile.h (left):

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h...
cc/tiles/prioritized_tile.h:22: PrioritizedTile(const PrioritizedTile& other);
On 2016/07/14 21:19:08, danakj wrote:
> Can it be DISALLOW_COPY_AND_ASSIGN?

No, it's still being copied...

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h
File cc/tiles/prioritized_tile.h (right):

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h...
cc/tiles/prioritized_tile.h:35: friend class PictureLayerTiling;
On 2016/07/14 21:19:08, danakj wrote:
> can it be gone?

Done.

https://codereview.chromium.org/2150473003/diff/1/cc/tiles/prioritized_tile.h...
cc/tiles/prioritized_tile.h:37: PrioritizedTile(Tile* tile,
On 2016/07/14 21:19:08, danakj wrote:
> can it be public?

Done.

[danakj, 2016-07-14 21:49:25]

OK LGTM

[vmpstr, 2016-07-14 21:50:54]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-07-14 21:51:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 21:51:31]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-14 22:56:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 22:56:58]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 22:58:59]

Description was changed from

==========
cc: Eliminate refcount churn in prioritized tile's raster source.

This patch saves about 5% time during prepare tiles by eliminating
unnecessary refcount churn when copying prioritized tiles around in
the raster tile priority queues.

R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Eliminate refcount churn in prioritized tile's raster source.

This patch saves about 5% time during prepare tiles by eliminating
unnecessary refcount churn when copying prioritized tiles around in
the raster tile priority queues.

R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/9f7eaff141b728bca75df40e70d53edb6da25ce3
Cr-Commit-Position: refs/heads/master@{#405613}
==========

[commit-bot: I haz the power, 2016-07-14 22:59:00]

Patchset 2 (id:??) landed as
https://crrev.com/9f7eaff141b728bca75df40e70d53edb6da25ce3
Cr-Commit-Position: refs/heads/master@{#405613}