Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2150473002: Test ImportElement and fix PrefixElementZ.isTopLevel (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test ImportElement and fix PrefixElementZ.isTopLevel BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/9214293d2970f7b37925e90f99da576fa6ab862b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-13 08:27:49 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-13 17:15:30 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-15 07:47:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9214293d2970f7b37925e90f99da576fa6ab862b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698