ImageCapture.grabFrame()/<video>.captureStream(), use ABGR pixel format for Android

content/renderer/media/html_video_element_capturer_source.cc

Index: content/renderer/media/html_video_element_capturer_source.cc
diff --git a/content/renderer/media/html_video_element_capturer_source.cc b/content/renderer/media/html_video_element_capturer_source.cc
index 88108ee50e587c10a4fd89136333fa3f5d3e2ec1..50b82bdc0ccd3fb16964f9d6e7b4a59a57203d1f 100644
--- a/content/renderer/media/html_video_element_capturer_source.cc
+++ b/content/renderer/media/html_video_element_capturer_source.cc
@@ -156,6 +156,13 @@ void HtmlVideoElementCapturerSource::sendNewFrame() {
       base::TimeTicks::Now() - base::TimeTicks());
   DCHECK(frame);
 
+#if defined(OS_ANDROID)
+  // See https://crbug.com/627983.
+  const uint32 source_pixel_format = libyuv::FOURCC_ABGR;
+#else
+  const uint32 source_pixel_format = libyuv::FOURCC_ARGB;
+#endif
+
   if (libyuv::ConvertToI420(static_cast<uint8*>(bitmap.getPixels()),
                             bitmap.getSize(),
                             frame->data(media::VideoFrame::kYPlane),
@@ -171,7 +178,7 @@ void HtmlVideoElementCapturerSource::sendNewFrame() {
                             frame->coded_size().width(),
                             frame->coded_size().height(),
                             libyuv::kRotate0,
-                            libyuv::FOURCC_ARGB) == 0) {
+                            source_pixel_format) == 0) {

[emircan, 2016/07/14 18:16:00]

I think the underlying problem is that bitmap.colorType() which is
kN32_SkColorType is defined differently on some platforms. It is based on
SK_PMCOLOR_BYTE_ORDER which is detected at compile time. Android might not
always be ABGR. 
1) You can base on SK_PMCOLOR_BYTE_ORDER as in [0]
2) kN32_SkColorType == kBGRA_8888_SkColorType ? libyuv::FOURCC_ARGB :
libyuv::FOURCC_ABGR

[0]
https://cs.chromium.org/chromium/src/third_party/skia/include/core/SkImageInf...

[mcasas, 2016/07/14 18:33:08]

Great suggestion! Done.

     // Success!
     io_task_runner_->PostTask(
         FROM_HERE, base::Bind(new_frame_callback_, frame, current_time));