third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/CSSSelectorWatch.h ('K') | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | third_party/WebKit/public/web/WebFrameWidget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 3dc1d8305682699a68763efa2ebe2dfcb15c50c9..1790654fdfcd32ad9f7355386a19b59afd14284c 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -4516,14 +4516,14 @@ void WebViewImpl::forceNextDrawingBufferCreationToFail()

DrawingBuffer::forceNextDrawingBufferCreationToFail();

}

-CompositorProxyClient* WebViewImpl::createCompositorProxyClient()

+CompositorProxyClient* WebViewImpl::createCompositorProxyClient(WorkerClients& clients)

{

if (!m_mutator) {

std::unique_ptr<CompositorMutatorClient> mutatorClient = CompositorMutatorImpl::createClient();

m_mutator = static_cast<CompositorMutatorImpl*>(mutatorClient->mutator());

m_layerTreeView->setMutatorClient(std::move(mutatorClient));

}

- return new CompositorProxyClientImpl(m_mutator);

+ return new CompositorProxyClientImpl(m_mutator, clients);

}

void WebViewImpl::updatePageOverlays()