third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/Supplementable.h ('K') | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/CompositorProxyClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index c122b748d3ca6915260bbfefec48538f1d5a06ed..d7be54e18afdbf78d670f5ea205d86fd0283a62f 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -1048,10 +1048,10 @@ void ChromeClientImpl::didUpdateTopControls() const

m_webView->didUpdateTopControls();

}

-CompositorProxyClient* ChromeClientImpl::createCompositorProxyClient(LocalFrame* frame)

+CompositorProxyClient* ChromeClientImpl::createCompositorProxyClient(LocalFrame* frame, WorkerClients& clients)

{

WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(frame);

- return webFrame->localRoot()->frameWidget()->createCompositorProxyClient();

+ return webFrame->localRoot()->frameWidget()->createCompositorProxyClient(clients);

}

void ChromeClientImpl::registerPopupOpeningObserver(PopupOpeningObserver* observer)