third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp - Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp ('K') | « third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp ('k') | third_party/WebKit/Source/platform/Supplementable.h » ('j') | third_party/WebKit/Source/platform/Supplementable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

index bc13d96e28292b56c29de1297a0eda232e26566c..8990f9f26a6a768a7a8d5419b32f9cc25e0d9b25 100644

--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

@@ -66,7 +66,10 @@ class TestCompositorProxyClient

, public CompositorProxyClient {

USING_GARBAGE_COLLECTED_MIXIN(TestCompositorProxyClient);

public:

- TestCompositorProxyClient() {}

+ explicit TestCompositorProxyClient(WorkerClients& clients)

+ : CompositorProxyClient(clients)

+ {

+ }

void setGlobalScope(WorkerGlobalScope*) override {}

void requestAnimationFrame() override {}

@@ -115,7 +118,7 @@ public:

{

std::unique_ptr<CompositorWorkerThread> workerThread = CompositorWorkerThread::create(nullptr, *m_objectProxy, 0);

WorkerClients* clients = WorkerClients::create();

- provideCompositorProxyClientTo(clients, new TestCompositorProxyClient);

+ provideCompositorProxyClientTo(clients, new TestCompositorProxyClient(*clients));

workerThread->start(WorkerThreadStartupData::create(

KURL(ParsedURLString, "http://fake.url/"),

"fake user agent",