Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp

Issue 2150443002: Supplement should have a Member to the corresponding Supplementable object (Part 1) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 27 matching lines...) Expand all
38 #include "core/frame/LocalFrame.h" 38 #include "core/frame/LocalFrame.h"
39 #include "core/loader/FrameLoaderClient.h" 39 #include "core/loader/FrameLoaderClient.h"
40 #include "core/style/StyleRareNonInheritedData.h" 40 #include "core/style/StyleRareNonInheritedData.h"
41 41
42 namespace blink { 42 namespace blink {
43 43
44 // The address of this string is important; its value is just documentation. 44 // The address of this string is important; its value is just documentation.
45 static const char kSupplementName[] = "CSSSelectorWatch"; 45 static const char kSupplementName[] = "CSSSelectorWatch";
46 46
47 CSSSelectorWatch::CSSSelectorWatch(Document& document) 47 CSSSelectorWatch::CSSSelectorWatch(Document& document)
48 : m_document(document) 48 : Supplement<Document>(document)
49 , m_document(document)
sof 2016/07/13 07:41:57 Do you need m_document any longer?
haraken 2016/07/13 07:44:55 This is exactly what I wanted to remove :) Removed
49 , m_callbackSelectorChangeTimer(this, &CSSSelectorWatch::callbackSelectorCha ngeTimerFired) 50 , m_callbackSelectorChangeTimer(this, &CSSSelectorWatch::callbackSelectorCha ngeTimerFired)
50 , m_timerExpirations(0) 51 , m_timerExpirations(0)
51 { 52 {
52 } 53 }
53 54
54 CSSSelectorWatch& CSSSelectorWatch::from(Document& document) 55 CSSSelectorWatch& CSSSelectorWatch::from(Document& document)
55 { 56 {
56 CSSSelectorWatch* watch = fromIfExists(document); 57 CSSSelectorWatch* watch = fromIfExists(document);
57 if (!watch) { 58 if (!watch) {
58 watch = new CSSSelectorWatch(document); 59 watch = new CSSSelectorWatch(document);
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 } 164 }
164 165
165 DEFINE_TRACE(CSSSelectorWatch) 166 DEFINE_TRACE(CSSSelectorWatch)
166 { 167 {
167 visitor->trace(m_watchedCallbackSelectors); 168 visitor->trace(m_watchedCallbackSelectors);
168 visitor->trace(m_document); 169 visitor->trace(m_document);
169 Supplement<Document>::trace(visitor); 170 Supplement<Document>::trace(visitor);
170 } 171 }
171 172
172 } // namespace blink 173 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698