Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2150433003: Initialize use_ios_simulator from current_cpu. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize use_ios_simulator from current_cpu. It is technically possible to build a fat binary that works on both simulator and device, thus the use_ios_simulator value depends on the cpu from the current toolchain (aka current_cpu) and not the cpu from the default toolchain (aka target_cpu). BUG=625875 Committed: https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431 Cr-Commit-Position: refs/heads/master@{#405970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/ios/ios_sdk.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-07-13 11:01:13 UTC) #3
brettw
lgtm
4 years, 5 months ago (2016-07-13 22:16:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150433003/1
4 years, 5 months ago (2016-07-18 08:57:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 09:51:21 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 09:54:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43b9c63e834916b79837e5c57e52e31adc23d431
Cr-Commit-Position: refs/heads/master@{#405970}

Powered by Google App Engine
This is Rietveld 408576698