Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2150413002: Use node() when generating element id's (Closed)

Created:
4 years, 5 months ago by Ian Vollick
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Use node() when generating element id's The current code followed the lead of crrev.com/279553002 and incorrectly used generatingNode, which lead to discrepancies when animating pseudo elements. It seems that node() is the correct choice, both here and in the CL I referenced. BUG=626571 Review-Url: https://codereview.chromium.org/2141743002 Cr-Commit-Position: refs/heads/master@{#404921} (cherry picked from commit 10b3fec07dfda5c362f1fc27a314468541c72ae0) Committed: https://chromium.googlesource.com/chromium/src/+/8b49a371fb95d08b33bd3d35ac87e41186ff19de

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Ian Vollick
4 years, 5 months ago (2016-07-15 18:34:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b49a371fb95d08b33bd3d35ac87e41186ff19de.

Powered by Google App Engine
This is Rietveld 408576698