Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2150393003: Fix referrerPolicy IDL attribute spelling (Closed)

Created:
4 years, 5 months ago by estark
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix referrerPolicy IDL attribute spelling In the grand tradition of trivial HTTP-referrer-related misspellings that haunt the web forever, I miscapitalized the referrerPolicy IDL attribute. This CL fixes the mistake for compatibility with Firefox and the spec (see for example https://html.spec.whatwg.org/multipage/semantics.html#the-a-element). BUG=628718 Committed: https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539 Cr-Commit-Position: refs/heads/master@{#406311}

Patch Set 1 #

Patch Set 2 : update layout tests #

Patch Set 3 : update more layout tests #

Messages

Total messages: 13 (5 generated)
estark
jochen, PTAL?
4 years, 5 months ago (2016-07-15 20:00:17 UTC) #3
jochen (gone - plz use gerrit)
just to make sure we don't get screamed at later, what about sending a short ...
4 years, 5 months ago (2016-07-15 20:20:32 UTC) #4
estark
On 2016/07/15 20:20:32, jochen wrote: > just to make sure we don't get screamed at ...
4 years, 5 months ago (2016-07-15 20:34:37 UTC) #5
estark
Bumping this up again because no one on blink-dev has screamed yet.
4 years, 5 months ago (2016-07-18 22:17:47 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-19 12:22:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150393003/40001
4 years, 5 months ago (2016-07-19 15:54:54 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 18:03:34 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:05:26 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c3b9e79b591bdf2fdea29c1f44f455f124f2539
Cr-Commit-Position: refs/heads/master@{#406311}

Powered by Google App Engine
This is Rietveld 408576698