Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2150383002: Fixed the look of the pin input. (Closed)

Created:
4 years, 5 months ago by sammiequon
Modified:
4 years, 5 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed the look of the pin input. The pin input right now is too tall, and a unwanted blue outline shows up around it. BUG=627937 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/189a2edbe996f9957aa03f97161d353d1232f31f Cr-Commit-Position: refs/heads/master@{#406091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sammiequon
jdufault@, xiyuan@ - Please take a look.
4 years, 5 months ago (2016-07-15 19:58:48 UTC) #4
jdufault
On 2016/07/15 19:58:48, sammiequon wrote: > jdufault@, xiyuan@ - Please take a look. lgtm, but ...
4 years, 5 months ago (2016-07-15 20:01:24 UTC) #5
xiyuan
lgtm
4 years, 5 months ago (2016-07-18 17:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150383002/1
4 years, 5 months ago (2016-07-18 18:51:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 21:04:56 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:08:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/189a2edbe996f9957aa03f97161d353d1232f31f
Cr-Commit-Position: refs/heads/master@{#406091}

Powered by Google App Engine
This is Rietveld 408576698