Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2150373002: [Chromecast] Put the run test list in runtime deps. (Closed)

Created:
4 years, 5 months ago by sanfin
Modified:
4 years, 5 months ago
Reviewers:
halliwell, Simeon, mbjorge, slan
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Put the run test list in runtime deps. This allows us to automatically include the file when we use gn desc runtime_deps to isolate a test group and its runtime dependencies. BUG=internal b/30140639 TEST=Run gn desc out/release chromecast:cast_test_lists, verify contains out/release/tests/run_test_list.txt Committed: https://crrev.com/88b70de70189fb00e8ff742c19960907a77e32a1 Cr-Commit-Position: refs/heads/master@{#405888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chromecast/build/tests/cast_test.gni View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Simeon
With this change, we are able to get a complete list of all the files, ...
4 years, 5 months ago (2016-07-15 17:41:11 UTC) #2
mbjorge
lgtm
4 years, 5 months ago (2016-07-15 17:57:18 UTC) #3
halliwell
On 2016/07/15 17:57:18, mbjorge wrote: > lgtm lgtm
4 years, 5 months ago (2016-07-15 18:45:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150373002/1
4 years, 5 months ago (2016-07-15 20:53:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 22:54:26 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 22:54:39 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 22:56:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88b70de70189fb00e8ff742c19960907a77e32a1
Cr-Commit-Position: refs/heads/master@{#405888}

Powered by Google App Engine
This is Rietveld 408576698