Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: tests/SkDOMTest.cpp

Issue 2150353002: Make XML compilation conditional. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/xml.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/SkDOMTest.cpp
diff --git a/tests/SkDOMTest.cpp b/tests/SkDOMTest.cpp
index aca2c4870bb58943435a5a223aefd9f1c1b0470b..7d170dcc27621b9dfaef9a1bb39eb4bf6c2d471c 100644
--- a/tests/SkDOMTest.cpp
+++ b/tests/SkDOMTest.cpp
@@ -8,6 +8,8 @@
#include "SkDOM.h"
#include "Test.h"
+#if defined(SK_XML)
dogben 2016/07/15 14:41:41 Does this need to be before the includes?
f(malita) 2016/07/15 14:46:30 There's a presubmit check I tripped while trying t
mtklein 2016/07/15 16:20:32 The presubmit is there to guard against #ifdef SK
f(malita) 2016/07/15 16:47:55 Done.
+
DEF_TEST(SkDOM_test, r) {
static const char gDoc[] =
"<root a='1' b='2'>"
@@ -37,3 +39,5 @@ DEF_TEST(SkDOM_test, r) {
REPORTER_ASSERT(r, dom.getFirstChild(root, "elem1"));
REPORTER_ASSERT(r, !dom.getFirstChild(root, "subelem1"));
}
+
+#endif // SK_XML
« no previous file with comments | « gyp/xml.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698