[DevTools] Compatibility with old STL libraries

[DevTools] Compatibility with older STL libraries

One of the clients need to support Mac OS X version 10.7, which means that Clang compiler that support C++11 is used but the application is linked against pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org

Committed: https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe
Cr-Commit-Position: refs/heads/master@{#406103}

[eostroukhov-old, 2016-07-15 23:06:50]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 23:07:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-15 23:08:17]

Description was changed from

==========
[DevTools] Compatibility with node.js build

Node.JS build sets minimum supported Mac OS X version to 10.7, which
means that Clang compiler that support C++11 is used but the application
is linked against pre-C++11 libstdc++.

Following changes were made for compatibility:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Compatibility with older STL libraries

One of the clients need to support Mac OS X version 10.7, which means that Clang
compiler that support C++11 is used but the application is linked against
pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org
==========

[eostroukhov-old, 2016-07-15 23:08:36]

Please review.

[pfeldman, 2016-07-15 23:14:07]

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/Collections.h
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/Collections.h:17: template
<class Key, class T> using HashMap = std::map<Key, T>;
You still want some HashMap for non Apple, right?

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h:161: PtrType
internalRelease() const
How is this different from release()

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h:227: PtrType
ptr = m_ptr;
Looks like the same code as below, reuse?

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/String16STL.h
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/String16STL.h:246: #if
!defined(__APPLE__) || defined(_LIBCPP_VERSION)
Drop this, we always want it by default.

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:218:
m_state->getInteger(DebuggerAgentState::pauseOnExceptionsState, &pauseState);
Why did this change?

[eostroukhov-old, 2016-07-15 23:45:53]

Thank you for the review. I addressed the comments, please take another look.

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/Collections.h
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/Collections.h:17: template
<class Key, class T> using HashMap = std::map<Key, T>;
On 2016/07/15 23:14:07, pfeldman wrote:
> You still want some HashMap for non Apple, right?

unordered_map will be used.

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h:161: PtrType
internalRelease() const
On 2016/07/15 23:14:07, pfeldman wrote:
> How is this different from release()

This is an ugly hack - this method is actually const, allowing "copying" from a
const reference.

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h:227: PtrType
ptr = m_ptr;
On 2016/07/15 23:14:07, pfeldman wrote:
> Looks like the same code as below, reuse?

Done.

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/String16STL.h
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/String16STL.h:246: #if
!defined(__APPLE__) || defined(_LIBCPP_VERSION)
On 2016/07/15 23:14:07, pfeldman wrote:
> Drop this, we always want it by default.

This is not compatible with old STL - that one does not have an std::hash to
specialize.

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/2150333003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:218:
m_state->getInteger(DebuggerAgentState::pauseOnExceptionsState, &pauseState);
On 2016/07/15 23:14:07, pfeldman wrote:
> Why did this change?

Oops, it didn't.

[pfeldman, 2016-07-16 00:08:51]

You should upload the new patch.

[commit-bot: I haz the power, 2016-07-16 00:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 00:26:48]

Dry run: This issue passed the CQ dry run.

[eostroukhov-old, 2016-07-18 16:16:10]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[eostroukhov-old, 2016-07-18 16:16:52]

On 2016/07/16 00:08:51, pfeldman wrote:
> You should upload the new patch.

Oops, it was stuck on the patch set name prompt over the weekend. Sorry. I
uploaded it.

[commit-bot: I haz the power, 2016-07-18 16:16:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 17:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 17:37:33]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-07-18 18:08:51]

lgtm

[eostroukhov-old, 2016-07-18 18:32:29]

The CQ bit was checked by eostroukhov@google.com

[eostroukhov-old, 2016-07-18 18:32:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2150333003/#ps40001
(title: "Fixed typo in the build file.")

[commit-bot: I haz the power, 2016-07-18 18:34:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 20:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 20:03:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eostroukhov-old, 2016-07-18 20:07:12]

The CQ bit was checked by eostroukhov@google.com

[commit-bot: I haz the power, 2016-07-18 20:07:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 21:35:49]

Description was changed from

==========
[DevTools] Compatibility with older STL libraries

One of the clients need to support Mac OS X version 10.7, which means that Clang
compiler that support C++11 is used but the application is linked against
pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Compatibility with older STL libraries

One of the clients need to support Mac OS X version 10.7, which means that Clang
compiler that support C++11 is used but the application is linked against
pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-07-18 21:35:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 21:36:21]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 21:37:12]

Description was changed from

==========
[DevTools] Compatibility with older STL libraries

One of the clients need to support Mac OS X version 10.7, which means that Clang
compiler that support C++11 is used but the application is linked against
pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Compatibility with older STL libraries

One of the clients need to support Mac OS X version 10.7, which means that Clang
compiler that support C++11 is used but the application is linked against
pre-C++11 libstdc++.

Following changes were made:
1. std::unique_ptr got a new copy ctor that take a const ref - this
   allows for the pointer to be put into STL containers that do not
   support rvalue references.
2. cbegin/cend functions are no longer used.
3. Paths were changed and conditional macros were adjusted.

BUG=628794
R=pfeldman@chromium.org

Committed: https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe
Cr-Commit-Position: refs/heads/master@{#406103}
==========

[commit-bot: I haz the power, 2016-07-18 21:37:13]

Patchset 3 (id:??) landed as
https://crrev.com/851972d6da7463c353d712d2cb6c1ec23fa6c4fe
Cr-Commit-Position: refs/heads/master@{#406103}