Disallow user overrides to enterprise policy for plugins.

Disallow user overrides to enterprise policy for plugins.

This CL changes the code in two places:

Firstly, in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting
there was previously an exception for CONTENT_SETTING_ASK
which meant that it could override enterprise policy.

Secondly, in the UI, this disables the tick box to "Always
allowed to run" on chrome://plugins when enterprise policy
is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9610a5e34ea06ea1c9067f72224a62658620108c
Cr-Commit-Position: refs/heads/master@{#406197}

[Will Harris, 2016-07-15 23:05:15]

Description was changed from

==========
do not

BUG=
==========

to

==========
do not

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Will Harris, 2016-07-15 23:08:53]

Description was changed from

==========
do not

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Do not allow user configuration to override enterprise policy for plugins.

This CL changes the code in two places:

Firstly in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting there was previously
an exception for CONTENT_SETTING_ASK which meant that it could override
enterprise policy.

Secondly in the UI this disables the tick box to "Always allowed to run" when
enterprise policy is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Will Harris, 2016-07-15 23:10:43]

Description was changed from

==========
Do not allow user configuration to override enterprise policy for plugins.

This CL changes the code in two places:

Firstly in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting there was previously
an exception for CONTENT_SETTING_ASK which meant that it could override
enterprise policy.

Secondly in the UI this disables the tick box to "Always allowed to run" when
enterprise policy is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Disallow user overrides to enterprise policy for plugins.

This CL changes the code in two places:

Firstly, in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting
there was previously an exception for CONTENT_SETTING_ASK
which meant that it could override enterprise policy.

Secondly, in the UI, this disables the tick box to "Always
allowed to run" on chrome://plugins when enterprise policy
is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Will Harris, 2016-07-18 20:54:34]

wfh@chromium.org changed reviewers:
+ bauerb@chromium.org, tommycli@chromium.org

[Will Harris, 2016-07-18 20:55:36]

PTAL

tommycli -> because I'm changing your logic a bit
bauerb -> everything else.

[Bernhard Bauer, 2016-07-18 21:57:57]

lgtm

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/resources/pl...
File chrome/browser/resources/plugins.js (right):

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/resources/pl...
chrome/browser/resources/plugins.js:261: return plugin.policy_click_to_play ==
true;
Nit: Really, the == true is a bit overkill if we know (as defined by the Mojo
API) that the field is always going to be a boolean.

[Will Harris, 2016-07-18 22:02:41]

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/resources/pl...
File chrome/browser/resources/plugins.js (right):

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/resources/pl...
chrome/browser/resources/plugins.js:261: return plugin.policy_click_to_play ==
true;
On 2016/07/18 21:57:57, Bernhard Bauer wrote:
> Nit: Really, the == true is a bit overkill if we know (as defined by the Mojo
> API) that the field is always going to be a boolean.

Ack. I was just sticking with the convention in all the other functions.

[tommycli, 2016-07-18 22:33:16]

lgtm sans nit

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/plugins/plug...
File chrome/browser/plugins/plugin_info_message_filter.cc (right):

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/plugins/plug...
chrome/browser/plugins/plugin_info_message_filter.cc:495: general_info.source ==
content_settings::SETTING_SOURCE_POLICY;
nit: since we only use use_policy once, just inline into next line

[Will Harris, 2016-07-18 23:07:15]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-07-18 23:07:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2150323003/#ps20001
(title: "nits and owners")

[commit-bot: I haz the power, 2016-07-18 23:08:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2016-07-19 02:13:49]

thanks for review

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/plugins/plug...
File chrome/browser/plugins/plugin_info_message_filter.cc (right):

https://codereview.chromium.org/2150323003/diff/1/chrome/browser/plugins/plug...
chrome/browser/plugins/plugin_info_message_filter.cc:495: general_info.source ==
content_settings::SETTING_SOURCE_POLICY;
On 2016/07/18 22:33:16, tommycli wrote:
> nit: since we only use use_policy once, just inline into next line

Done.

[commit-bot: I haz the power, 2016-07-19 02:58:34]

Description was changed from

==========
Disallow user overrides to enterprise policy for plugins.

This CL changes the code in two places:

Firstly, in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting
there was previously an exception for CONTENT_SETTING_ASK
which meant that it could override enterprise policy.

Secondly, in the UI, this disables the tick box to "Always
allowed to run" on chrome://plugins when enterprise policy
is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Disallow user overrides to enterprise policy for plugins.

This CL changes the code in two places:

Firstly, in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting
there was previously an exception for CONTENT_SETTING_ASK
which meant that it could override enterprise policy.

Secondly, in the UI, this disables the tick box to "Always
allowed to run" on chrome://plugins when enterprise policy
is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-19 02:58:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 02:58:39]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 03:00:05]

Description was changed from

==========
Disallow user overrides to enterprise policy for plugins.

This CL changes the code in two places:

Firstly, in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting
there was previously an exception for CONTENT_SETTING_ASK
which meant that it could override enterprise policy.

Secondly, in the UI, this disables the tick box to "Always
allowed to run" on chrome://plugins when enterprise policy
is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Disallow user overrides to enterprise policy for plugins.

This CL changes the code in two places:

Firstly, in the actual plugin loading logic, in
PluginInfoMessageFilter::Context::GetPluginContentSetting
there was previously an exception for CONTENT_SETTING_ASK
which meant that it could override enterprise policy.

Secondly, in the UI, this disables the tick box to "Always
allowed to run" on chrome://plugins when enterprise policy
is CONTENT_SETTING_ASK (3).

BUG=616218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9610a5e34ea06ea1c9067f72224a62658620108c
Cr-Commit-Position: refs/heads/master@{#406197}
==========

[commit-bot: I haz the power, 2016-07-19 03:00:06]

Patchset 2 (id:??) landed as
https://crrev.com/9610a5e34ea06ea1c9067f72224a62658620108c
Cr-Commit-Position: refs/heads/master@{#406197}